46 docker backend #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions to login and registration views
…s in home and an instructions view, added a logo to the navbar
…do without functionality yet)
…inks to redirect work good.
-The call to our inner API works -Needed to add security changes in order to fullfil the CORS mechanism and allow to call our API from the webapp port
-Quetion generator need to run Main.java inside wiq_en1b\backend\wiq\src\main\java\com\wiq\wiq\services\questionGenerator To test the webapp and the backend -Run SpringBoot with the VSCode Extension and class WIQApplication.java inside wiq_en1b\backend\wiq\src\main\java\com\wiq\wiq -Go in console to webapp dir, then do npm install and the npm start
…ull cycle, start playing, generate the questions and then show them
Closed
UO289845
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
If I understood it correctly, the reason the checks fail is because you're changing the thing the checks are testing, so no problem there.
There's a lot of commented code, which may cause problems with SonarCloud, so I would recommend to maybe copy the commented code locally and remove it from the repository.
Nevertheless, the rest looks good, so I'll aprove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested the new dockerfile for the backend and the docker-compose