Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MurMur3の追加及び既存の文字列比較の置換対応 #59

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

AsPJT
Copy link
Owner

@AsPJT AsPJT commented Oct 14, 2023

No description provided.

@AsPJT AsPJT requested a review from guinpen98 October 14, 2023 04:30
Library/PAX_GRAPHICA/Key.hpp Show resolved Hide resolved
Library/PAX_GRAPHICA/Key.hpp Show resolved Hide resolved
Library/PAX_GRAPHICA/Key.hpp Show resolved Hide resolved
Copy link
Collaborator

@guinpen98 guinpen98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントを書いてください

@AsPJT
Copy link
Owner Author

AsPJT commented Oct 14, 2023

MurMur3 のコメントを追加しました。

@guinpen98
Copy link
Collaborator

MurMur3の単体テストを追加してください

@AsPJT
Copy link
Owner Author

AsPJT commented Oct 16, 2023

MurMur3の追加機能の改良を行いました。
単体テストの書き方やルールのドキュメントが整備されていないため、整備されるまでMurMur3の単体テストの記述は見送ります。
先に単体テストの書き方やルールをドキュメント化してください。

@AsPJT AsPJT merged commit b86b849 into develop Oct 18, 2023
5 checks passed
@AsPJT AsPJT deleted the feature-add-murmur3 branch October 18, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants