Skip to content

Commit

Permalink
Merge pull request #276 from AsherGlick/fixing_test_text
Browse files Browse the repository at this point in the history
Fixing some minor issues in the integration tests harness
  • Loading branch information
AsherGlick authored Feb 28, 2024
2 parents 7d7682f + 1869833 commit c9965fa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion xml_converter/integration_tests/run_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ def diff_dirs(actual_output_dir: str, expected_output_dir: str) -> bool:

if len_diff(diff) != 0:
diff_found = True
print("XML output was incorrect for test")
print("Output was incorrect for test")
for line in diff:
print(line)

Expand Down
2 changes: 1 addition & 1 deletion xml_converter/integration_tests/src/proto_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def compare_protos(
expected_textproto = get_waypoint_textproto(expected_proto_path)
actual_textproto = get_waypoint_textproto(actual_proto_path)

diff = list(difflib.unified_diff(expected_textproto.split("\n"), actual_textproto.split("\n"), fromfile=expected_proto_path, tofile=actual_proto_path, lineterm=""))
diff = list(difflib.unified_diff(actual_textproto.split("\n"), expected_textproto.split("\n"), fromfile=actual_proto_path, tofile=expected_proto_path, lineterm=""))

if len(diff) == 0:
diff = ["Something went wrong diffing {} and {}.".format(expected_proto_path, actual_proto_path)]
Expand Down

0 comments on commit c9965fa

Please sign in to comment.