String Hierarchy Utility Functions #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some string hierarchy utility functions that allow for some minor optimizations when calling string hierarchy functions with a single path, by not requiring that a vector be created to house the path.
It also introduces sub_hierarchy functionality so that hierarchy don't need to be queried from the root, allowing for recursive traversal the category tree without requiring a full hierarchy path be constructed or maintained.
Lastly it fixes up some incorrect linter checks that were mostly passing because the linter was looking at the existing code to try and determine what the rule should be. But now it is explicitly that pointer*s should be attached to the type, and reference&s should be attached to the variable.The linter change turned out to be widespread. It will be moved to its own pr.