-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute test harness #184
Merged
AsherGlick
merged 14 commits into
AsherGlick:xml_converter
from
klingbolt:att_test_harness
Oct 25, 2023
Merged
Attribute test harness #184
AsherGlick
merged 14 commits into
AsherGlick:xml_converter
from
klingbolt:att_test_harness
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed over and one case of a value being changed from zero to false.
AsherGlick
requested changes
Oct 22, 2023
Go ahead and close the PRs that are being rebased by this one. |
AsherGlick
requested changes
Oct 25, 2023
AsherGlick
requested changes
Oct 25, 2023
xml_converter/test_cases/can_fade/inputs/can_fade_is_correct.xml
Outdated
Show resolved
Hide resolved
AsherGlick
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This python script and tests can be used to validate the output of
xmlconverter.cpp
against a known value so that we can catch any issues.This PR only takes in an xml and writes to xml. The plan is to establish the framework here so that more tests can be written.
This PR is a rebase of PR #178 and makes it obsolete.