Reworking copying functions to only copy files for textures

[klingbolt]

The goal of this PR was to make it explicit when we want to copy images from an input folder to an output folder. Since this is adding copying files from the new protobin folders, I standardized how those are read to match the taco directories.

[AsherGlick]

When would we have a situation where we have an output file and we dont want to copy files?

[klingbolt]

We had previously mentioned if you are using the program simply as a linter, you would not want to copy them over.

Perhaps we want to make that the optional case then and default to copying them.

[AsherGlick]

And in that conversation we had also come to the conclusion that if you were using the xml_converter as only a linter you would not have an output file.

[klingbolt]

Ah I had not remembered that. I'll make adjustments.

[klingbolt]

This change should now copy only the files that used as textures. In addition, the ability to read proto texture indexes was added.

[AsherGlick]

I reviewed part of this but it looks like there are some changes that are not totally necessary or thought out. I'm going to pass it back to you with only whatever notes I have so far so you can go over it again yourself first before sending it back again.

For example you changed a state variable from a string to a cstr and then because of that change you added a bunch of extra random function calls to deal with everything that cstr interacted with expecting a string.

Another is that you took the name filedir from the proto writer state struct and replaced other more descriptive names. I am not really sure what filedir is and probably that variable name should have been changed instead of being propagated throughout the codebase.

[github-actions]

Full Diff

--- xml_converter/integration_tests/test_cases/texture/output_proto/markers.bin.textproto._old	2024-03-18 01:20:59.122077476 +0000
+++ xml_converter/integration_tests/test_cases/texture/output_proto/markers.bin.textproto._new	2024-03-18 01:20:59.130077442 +0000
@@ -21,11 +21,11 @@
 textures {
 }
 textures {
-  filepath: "my_texture.png"
+  filepath: "texture_one.png"
 }
 textures {
-  filepath: "my_texture2.png"
+  filepath: "texture_two.png"
 }
 textures {
-  filepath: "somedir/my_texture3.png"
+  filepath: "somedir/texture_three.png"
 }

[github-actions]

Full Diff

--- xml_converter/integration_tests/test_cases/texture/output_proto/markers.bin.textproto._old	2024-04-20 22:56:53.572116768 +0000
+++ xml_converter/integration_tests/test_cases/texture/output_proto/markers.bin.textproto._new	2024-04-20 22:56:53.580116633 +0000
@@ -21,11 +21,11 @@
 textures {
 }
 textures {
-  filepath: "my_texture.png"
+  filepath: "texture_one.png"
 }
 textures {
-  filepath: "my_texture2.png"
+  filepath: "texture_two.png"
 }
 textures {
-  filepath: "somedir/my_texture3.png"
+  filepath: "somedir/texture_three.png"
 }