Godot File Handler #268
Merged
Godot File Handler #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing files. Deleted obsolete JSON code
AsherGlick
requested changes
Jan 20, 2024
Everything was broken for saving. The nodes it was calling from never had anything written to it. |
AsherGlick
requested changes
Mar 13, 2024
AsherGlick
requested changes
Apr 21, 2024
AsherGlick
requested changes
May 18, 2024
FileHandler.gd
Outdated
| static func call_xml_converter(args: PoolStringArray): | ||
| var output: Array = [] | ||
| print(args) | ||
| var result: int = OS.execute("./xml_converter/build/xml_converter", args, true, output, true) |
There was a problem hiding this comment.
This can probably be a constant variable in FileHandler instead of a magic string here.
Also: does this work with the exported files? I think it is fine if not right now but we will need to test it to be sure.
AsherGlick
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed name of file that will hold all functions for loading and saving files. Also deleted the obsolete JSON code.