-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waypoint data the source of truth for position of icons and trails #316
Merged
AsherGlick
merged 5 commits into
AsherGlick:xml_converter
from
klingbolt:update_waypoints
Jun 17, 2024
Merged
Waypoint data the source of truth for position of icons and trails #316
AsherGlick
merged 5 commits into
AsherGlick:xml_converter
from
klingbolt:update_waypoints
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsherGlick
requested changes
Jun 12, 2024
AsherGlick
requested changes
Jun 14, 2024
AsherGlick
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any instance where the nodes for paths and icons were update should now update the waypoint datum first followed by updating the node if needed.
This covers any changes to position or deleting single points or icons.