Changed Textures to be assigned by waypoint texture ID #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingbolt
commented
Jun 23, 2024
AsherGlick
requested changes
Jun 23, 2024
There was a problem hiding this comment.
Overall your PRs seem to be improving the last couple weeks. Though this one should have been 2 PRs. One of those PRs, reading the texture path from the waypoint data, only needed some very minor changes. The other one, needs some more design work and user workflow consideration before merging.
…arching for existing files. Addressed code review
AsherGlick
reviewed
Aug 17, 2024
AsherGlick
reviewed
Aug 17, 2024
AsherGlick
reviewed
Aug 17, 2024
AsherGlick
reviewed
Aug 17, 2024
AsherGlick
reviewed
Aug 18, 2024
AsherGlick
reviewed
Aug 18, 2024
AsherGlick
reviewed
Aug 18, 2024
AsherGlick
reviewed
Aug 18, 2024
FileHandler.gd
Outdated
| dir.list_dir_end() | ||
| return current_relative_path | ||
| file_name = dir.get_next() | ||
| return "" |
There was a problem hiding this comment.
return null from this function when a file is not found instead of an empty string.
AsherGlick
requested changes
Aug 21, 2024
FileHandler.gd
Outdated
Comment on lines
45
to
46
| # These are all supported file types in Godot that are not supported | ||
| # by other marker programs. "jpg", "jpeg", "bmp", "tga" |
There was a problem hiding this comment.
We don't need this comment explaining what formats godot supports.
FileHandler.gd
Outdated
|
|
||
| static func find_file_duplicate(directory_path: String, target_name: String, target_content: PoolByteArray, relative_path: String): | ||
| var dir = Directory.new() | ||
| if dir.open(directory_path) == OK: |
There was a problem hiding this comment.
As discussed offline, switch this logic so you can unindent the code below.
AsherGlick
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move textures into the user data directory and assign new ID. XML converter will handle only saving the images that are used by the icons and trails so single deletion is not necessary at this time.