Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the current data to the map files #323

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

klingbolt
Copy link
Contributor

This covers the third issue in #267.

Saving the waypoint data to file

Copy link
Owner

@AsherGlick AsherGlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to search through the linked issue to find what the "third issue" was. I am assuming it is from this comment: #267 (review)

Did we change how we designed saving to work or am totally missing something in this PR?

Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
@klingbolt klingbolt requested a review from AsherGlick July 31, 2024 03:16
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
Spatial.gd Show resolved Hide resolved
Spatial.gd Outdated Show resolved Hide resolved
@AsherGlick AsherGlick merged commit 0b55fb7 into AsherGlick:xml_converter Aug 1, 2024
6 checks passed
@klingbolt klingbolt deleted the save_data branch September 11, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants