Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving Conflicts in Xml converter #354

Closed
wants to merge 730 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
730 commits
Select commit Hold shift + click to select a range
6af7877
Forgot to save in Godot
klingbolt Dec 15, 2023
cc1e225
Removing node from scene
klingbolt Dec 15, 2023
ce3d01e
Changed variable names of marker collections. Addressed other comments
klingbolt Dec 21, 2023
2dcb0f4
Missed some changes
klingbolt Dec 22, 2023
d322150
Merge pull request #233 from klingbolt/node_visibility
AsherGlick Dec 29, 2023
aee0a94
Rebuild the xml_converter when running integration tests
AsherGlick Dec 29, 2023
954652e
adding trail parsing example from github wiki
AsherGlick Dec 29, 2023
84a54a0
making all the state variables live as long as the generator instead …
AsherGlick Dec 29, 2023
845b499
adding method of indexing filepaths from the proto
AsherGlick Dec 30, 2023
32a53f8
Call xml converter from Godot
klingbolt Nov 17, 2023
36957cc
Merge pull request #247 from AsherGlick/rebuild_xml_test
AsherGlick Dec 30, 2023
fac7518
Merge pull request #248 from AsherGlick/trail_parser_example
AsherGlick Dec 30, 2023
1972c81
Merge pull request #249 from AsherGlick/state_lifetime
AsherGlick Dec 30, 2023
7f70e68
Merge pull request #250 from AsherGlick/path_indexes
AsherGlick Dec 30, 2023
428b7d0
reorganizing tests
AsherGlick Dec 30, 2023
41e6da1
fixing workflow to install python deps from the new location
AsherGlick Dec 30, 2023
4486a36
Adding a presubmit for integration tests and fixing the generators one
AsherGlick Dec 30, 2023
71fa725
renaming intigration_tests to integration_tests
AsherGlick Dec 30, 2023
5c1b9c6
adding a helpful comment to explain proto index rules
AsherGlick Dec 30, 2023
4df5c1b
Edit to scene from merge
klingbolt Dec 30, 2023
40a837b
Merge pull request #251 from AsherGlick/reorganizing_tests
AsherGlick Dec 31, 2023
f545715
Merge pull request #252 from AsherGlick/fixing_python_presubmit
AsherGlick Dec 31, 2023
a34ce44
Merge pull request #253 from AsherGlick/intigration_to_integration
AsherGlick Dec 31, 2023
478aa62
Merge branch 'proto_help_comment' into xml_converter
AsherGlick Dec 31, 2023
309d1b5
adding functionality to make use of xml write side effects
AsherGlick Dec 31, 2023
a0bb0a1
Writing out .trl files on xml export
AsherGlick Dec 31, 2023
7e37add
Linter check fixes
AsherGlick Dec 31, 2023
ff4da0c
Pruning usage of AttributeVariable and cleaning up associated code
AsherGlick Dec 31, 2023
681672f
fixing bug caused from bad linter fix
AsherGlick Dec 31, 2023
cad15fb
adding ability to specify proto writing side effects
AsherGlick Dec 31, 2023
62803ec
fixing trailing newline
AsherGlick Dec 31, 2023
ece36df
Added method to call xml_converter
klingbolt Jan 1, 2024
c941e84
Cleaning up code
klingbolt Jan 1, 2024
ec1df32
Added lines to ensure that the split folder is made correctly
klingbolt Jan 1, 2024
89fe1ed
Renamed reference to node
klingbolt Jan 1, 2024
3cf2a6a
Merge pull request #255 from AsherGlick/xml_write_side_effects
AsherGlick Jan 1, 2024
e0ceceb
Merge pull request #256 from AsherGlick/writing_trl_files
AsherGlick Jan 1, 2024
3adf80a
Removed dev data
klingbolt Jan 1, 2024
96c3fef
removed indent
klingbolt Jan 1, 2024
f103c4b
Removing custom print for now
klingbolt Jan 2, 2024
df4557a
renaming attribute_variable to attribute_component to match attribute…
AsherGlick Jan 2, 2024
c165177
fixing comment of attribute_varaible -> attribute_component
AsherGlick Jan 2, 2024
6480614
Removed extra line
klingbolt Jan 2, 2024
647ad63
Merge pull request #257 from AsherGlick/prune_attribute_variable_type
AsherGlick Jan 2, 2024
f76fd6c
Merge pull request #258 from AsherGlick/proto_write_side_effect
AsherGlick Jan 2, 2024
0d75c75
Merge pull request #259 from klingbolt/call_xml_converter
AsherGlick Jan 2, 2024
82e3047
Multi file integration testing
AsherGlick Jan 2, 2024
4722a4d
linter fixes
AsherGlick Jan 2, 2024
616fd09
Merge pull request #260 from AsherGlick/multifile_integration_tests
AsherGlick Jan 3, 2024
1453935
Made the field name and type case insensitive. Added tests to ensure …
klingbolt Jan 3, 2024
09ee085
Moved duplicate category to a 2nd file
klingbolt Jan 3, 2024
bbf82c9
Removing category line
klingbolt Jan 3, 2024
2fa4415
Merge pull request #261 from klingbolt/case_insensitive
AsherGlick Jan 3, 2024
00e35ee
Updated gdscript to reflect changes to texture field in proto
klingbolt Jan 3, 2024
622a391
Merge pull request #262 from klingbolt/godot_texture_id
AsherGlick Jan 3, 2024
14a0279
Added argument for copying files and standardized proto reading
klingbolt Jan 5, 2024
251d775
removing the copying argument
klingbolt Jan 5, 2024
9ad280d
Added textures to proto reader state
klingbolt Jan 12, 2024
9c78165
removing erroneous file
klingbolt Jan 12, 2024
56d9370
Moved structs into the packaging files and changed the data format of…
klingbolt Jan 19, 2024
f895ed4
fixing a segault that occurs if a category does not have a "name" att…
AsherGlick Jan 20, 2024
cdb4e5a
Changed name of file that will hold all functions for loading and sav…
klingbolt Jan 20, 2024
629d3ee
Removed extra lines
klingbolt Jan 20, 2024
a742a4d
Merge pull request #266 from AsherGlick/missing_name_segfault
AsherGlick Jan 20, 2024
e1187d5
adding a method to overlay the parseable classes on top of themselves
AsherGlick Jan 21, 2024
1223669
remoing the now unused find_attribute_value function
AsherGlick Jan 21, 2024
994d6d9
linter checks
AsherGlick Jan 22, 2024
fe1bf76
adding helper functions to generate simple hashed values
AsherGlick Jan 22, 2024
26907d1
Adding category id and auto-populating it if it is missing
AsherGlick Jan 22, 2024
b8862df
linter fixes
AsherGlick Jan 22, 2024
886a0dc
Adding a couple of sanity tests and making base64 logic more readable
AsherGlick Jan 22, 2024
22b824c
removing unused "state" warnings to highlight more important warnings
AsherGlick Jan 22, 2024
fc4e01d
Merge pull request #269 from AsherGlick/parseable_overlays
AsherGlick Jan 23, 2024
b2b6e78
Merge pull request #270 from AsherGlick/hashing_functions
AsherGlick Jan 23, 2024
540152d
adding doc file
AsherGlick Jan 23, 2024
8ff0e4d
Preventing xml node classes from forcing rebuilds when nothing changes
AsherGlick Feb 3, 2024
e9c9650
fixing linter
AsherGlick Feb 3, 2024
b0cb07b
adding arguments to the generator command
AsherGlick Feb 4, 2024
43d8f7d
removing sys import
AsherGlick Feb 4, 2024
1869833
Fixing some minor issues in the integration tests harness
AsherGlick Feb 4, 2024
82aa086
Adding a specific test for trail data
AsherGlick Feb 4, 2024
8d77e2a
adding a filter for the integration test harness
AsherGlick Feb 4, 2024
2649e7b
Merge pull request #271 from AsherGlick/category_id
AsherGlick Feb 4, 2024
9c27810
Merge pull request #272 from AsherGlick/base64_tests
AsherGlick Feb 4, 2024
36c7242
Merge pull request #273 from AsherGlick/removing_extra_states
AsherGlick Feb 4, 2024
8b4c71c
Merge pull request #274 from AsherGlick/prevent_required_rebuild
AsherGlick Feb 4, 2024
b8bfeba
Beginning to flesh out the html docs
AsherGlick Feb 5, 2024
7d7682f
Merge pull request #275 from AsherGlick/generator_arguments
AsherGlick Feb 5, 2024
87754e6
reworked typing and moved the copying function for xml images
klingbolt Feb 21, 2024
da49bb2
changed copying option
klingbolt Feb 21, 2024
c9965fa
Merge pull request #276 from AsherGlick/fixing_test_text
AsherGlick Feb 28, 2024
ccb21ed
Merge pull request #277 from AsherGlick/adding_trail_data_test
AsherGlick Feb 28, 2024
6d04c95
Merge pull request #278 from AsherGlick/test_harness_filter
AsherGlick Feb 28, 2024
6d720e2
Merge pull request #279 from AsherGlick/documentation_styles_1
AsherGlick Feb 28, 2024
fecd28d
Spliting xml converter functions into seperate file from dialogs
klingbolt Mar 3, 2024
10f7c71
removed extra space
klingbolt Mar 3, 2024
2f68f5c
addressing code review
klingbolt Mar 18, 2024
fbce0f4
Merge branch 'xml_converter' into copying_files
klingbolt Mar 18, 2024
06479ed
Fastforward to resolve conflict
klingbolt Mar 18, 2024
7f07be6
Changed the images in tests to smaller icons
klingbolt Mar 18, 2024
61b44e7
changed to static functions and updated naming
klingbolt Apr 3, 2024
e092bcc
removed metadata from images
klingbolt Apr 20, 2024
595ffdf
Merge pull request #264 from klingbolt/copying_files
AsherGlick Apr 20, 2024
b022773
Moved variables back to pack dialog
klingbolt Apr 27, 2024
7757841
Move variable creation to ready function
klingbolt Apr 27, 2024
bccee54
Removed lines from File Handler
klingbolt Apr 27, 2024
6919204
Change from clearing to creating a new object for data from file
klingbolt May 5, 2024
eb2a544
Merge pull request #282 from klingbolt/clear_waypoint
AsherGlick May 6, 2024
e333616
fixed function that calls only one program to only call that program.…
klingbolt May 17, 2024
6f0ee47
changed to constant variable
klingbolt May 18, 2024
8e68914
Merge pull request #268 from klingbolt/godot_file_handler
AsherGlick May 18, 2024
44a5343
adding sanity checks and usage to make_test.sh
AsherGlick May 19, 2024
76bb807
adding support for custom examples for fields
AsherGlick May 19, 2024
31db759
.
AsherGlick May 19, 2024
d874564
fixing some misconceptions about achivement bit
AsherGlick May 19, 2024
da77f3b
fixing all remaning incorrect references to bitmask
AsherGlick May 19, 2024
a4a2dc3
Adding integration tests for the "type" attribute
AsherGlick May 19, 2024
79e0586
making the implicit copy explicit
AsherGlick May 19, 2024
d23b00f
remaking how category inheritance works
AsherGlick May 19, 2024
a07c462
setting up a parallel method of accessing metadata contents
AsherGlick May 20, 2024
258c217
fixing metadata dataclasses for pre 3.10 python
AsherGlick May 20, 2024
eacede1
Merge pull request #285 from AsherGlick/make_test_sanity_checks
AsherGlick May 20, 2024
5c77cb5
Merge pull request #286 from AsherGlick/documentation_examples
AsherGlick May 20, 2024
53995fe
removing repeated test line
AsherGlick May 20, 2024
33a2ebd
fixing spacing
AsherGlick May 20, 2024
a808f24
migrate web docs to use dataclass metadata
AsherGlick May 20, 2024
c55b29f
Merge pull request #289 from AsherGlick/achivement_bit_fixes
AsherGlick May 20, 2024
42e6ed9
Merge pull request #290 from AsherGlick/marker_type_test
AsherGlick May 20, 2024
a9c2d12
Remove gizmo link function and move functionality
klingbolt May 20, 2024
57afb15
Merge pull request #293 from AsherGlick/inheritance_testing
AsherGlick May 21, 2024
78f0568
migrating the cpp generator to use dataclasses
AsherGlick May 21, 2024
76dfee5
removing the old json schema based validator
AsherGlick May 21, 2024
f3cd838
renaming metadata_dataclass to just metadata
AsherGlick May 21, 2024
53618cb
adding more examples to the documentation
AsherGlick May 21, 2024
8dab096
Added signals to paths and icon nodes
klingbolt May 22, 2024
e563c07
added typing and changed deselected to a signal
klingbolt May 22, 2024
62b8512
Attempting to upgrade the doc styles
AsherGlick May 22, 2024
66c8de2
Merge pull request #294 from AsherGlick/metadata_dataclass
AsherGlick May 24, 2024
5c92c7e
Merge pull request #295 from AsherGlick/dataclass_web_docs
AsherGlick May 25, 2024
4813721
Merge pull request #297 from AsherGlick/dataclass_cpp_generator
AsherGlick May 26, 2024
d5f02a2
Merge pull request #298 from AsherGlick/removing_jsonschema
AsherGlick May 26, 2024
21333c0
Merge pull request #299 from AsherGlick/adding_more_examples
AsherGlick May 26, 2024
e20570d
Merge pull request #301 from AsherGlick/webdoc_style_updates
AsherGlick May 26, 2024
b270b17
adding the ability to add examples to component fields
AsherGlick May 26, 2024
d434c2d
.
AsherGlick May 26, 2024
e908279
adding a list of known markerpacks for regression testing
AsherGlick May 26, 2024
d17792c
adding examples for compound fields based on their components
AsherGlick May 26, 2024
65ff849
adding the components of custom compound attributes to the web docs
AsherGlick May 26, 2024
84040b5
adding more examples to round out the core attributes
AsherGlick May 26, 2024
7318bc2
breaking out proto info inside AttributeVariable
AsherGlick May 27, 2024
3c54968
.
AsherGlick May 27, 2024
4e0daa1
breaking out xml info like proto info for consistency
AsherGlick May 27, 2024
eb0e8a0
Cleaning up all the unused AttributeVariable template fields
AsherGlick May 27, 2024
5976f18
Removing the requirement for protofields on each attribute
AsherGlick May 27, 2024
7930064
Simplifying rgbcolor to a single fixed32 field
AsherGlick May 27, 2024
97204bd
making it easier to read what include values are going where
AsherGlick May 27, 2024
0af1d97
switching from signals to function calls
klingbolt May 27, 2024
8404ea9
added missing type
klingbolt May 27, 2024
26c23e2
readded assignment of currently active path 2d
klingbolt May 27, 2024
96e0385
adding a negative y position example
AsherGlick May 27, 2024
da786f6
Merge pull request #303 from AsherGlick/component_examples
AsherGlick May 27, 2024
6f60bcb
Merge pull request #304 from AsherGlick/markerpack_source_database
AsherGlick May 27, 2024
f449e95
Merge pull request #305 from AsherGlick/compound_examples
AsherGlick May 27, 2024
b0e7dbe
Merge pull request #306 from AsherGlick/custom_compound_docs
AsherGlick May 27, 2024
968b3ac
Merge pull request #307 from AsherGlick/more_examples_2
AsherGlick May 27, 2024
de87be1
Merge pull request #308 from AsherGlick/break_out_proto_info
AsherGlick May 27, 2024
a12577b
Merge pull request #309 from AsherGlick/break_out_xml_info
AsherGlick May 27, 2024
28eae6f
Merge pull request #310 from AsherGlick/cleanup_unused_template_vars
AsherGlick May 27, 2024
0c4a322
Merge pull request #311 from AsherGlick/remove_proto_field_requirement
AsherGlick May 27, 2024
c41bb82
Merge pull request #312 from AsherGlick/simplifying_rgbcolor
AsherGlick May 27, 2024
0ed990b
Merge pull request #313 from AsherGlick/easier_include_readability
AsherGlick May 27, 2024
b1e858e
Addressing code review. Splits from using node to having explicit var…
klingbolt Jun 9, 2024
4376731
Small changes to address review
klingbolt Jun 9, 2024
5c702d0
Merge pull request #300 from klingbolt/remove_gizmo_link
AsherGlick Jun 10, 2024
6f80037
Made the waypoint data the source of truth for position of icons and …
klingbolt Jun 12, 2024
abcfdb8
added a type
klingbolt Jun 12, 2024
9b207cf
Changed from using index to passing Waypoint class
klingbolt Jun 14, 2024
872dee2
Changing the remove_icon function to pass in the icon
klingbolt Jun 14, 2024
7ea2173
Deleted obsolete functions and variables
klingbolt Jun 17, 2024
00752d0
Merge pull request #316 from klingbolt/update_waypoints
AsherGlick Jun 17, 2024
513f163
Changed all instances of the word path or route to Trail
klingbolt Jun 17, 2024
501f6bd
Changed to consistant x2d and x3d naming
klingbolt Jun 18, 2024
9227d6a
Merge pull request #318 from klingbolt/standardize_naming
AsherGlick Jun 18, 2024
2f7f02c
Changed Textures to be assigned by waypoint texture ID. Assign new ID…
klingbolt Jun 23, 2024
c139c97
Merge branch 'xml_converter' into texture_id_search
klingbolt Jun 23, 2024
354d67a
Update Spatial.gd
klingbolt Jun 23, 2024
c35d29f
Update Spatial.gd
klingbolt Jun 23, 2024
779370d
Updating the godobuf file to reflect recent changes to protobuf
klingbolt Jul 2, 2024
f66212b
Added a test for having a large array of textures. This one does not …
klingbolt Jul 2, 2024
081ab7f
Merge pull request #320 from klingbolt/update_godobuf_file
AsherGlick Jul 2, 2024
a3ef255
Reduced test to cover only a single instance
klingbolt Jul 2, 2024
3ef128d
Merge pull request #321 from klingbolt/texture_invalid
AsherGlick Jul 2, 2024
89774cd
Changed switching files to let user choose save location. Improved se…
klingbolt Jul 3, 2024
55ab881
Changes to not show the user directory when selecting a file
klingbolt Jul 8, 2024
3bf32de
Added toast command and removed erroneous node
klingbolt Jul 9, 2024
5fdec31
Fixed two small issues. bin is the new data format for proto files. 2…
klingbolt Jul 18, 2024
69eaab4
Merge pull request #322 from klingbolt/fixing_typos
AsherGlick Jul 19, 2024
477ed2f
Save the current data to the map files
klingbolt Jul 24, 2024
e021216
Added a check to save if the map changes
klingbolt Jul 24, 2024
5d0832d
Added hashing functionality and moved import function to allow simple…
klingbolt Jul 31, 2024
981cf43
added spaced in comments
klingbolt Jul 31, 2024
d4944b7
addressing code review
klingbolt Aug 1, 2024
0b55fb7
Merge pull request #323 from klingbolt/save_data
AsherGlick Aug 1, 2024
f3c605d
Merge branch 'xml_converter' into texture_id_search
klingbolt Aug 17, 2024
d6485cc
Fixing errors from conflict merge
klingbolt Aug 17, 2024
c1c9f42
Addressing code review. Small changes, new function for getting textu…
klingbolt Aug 18, 2024
14aa061
Fixing the category key when loading proto files
AsherGlick Aug 18, 2024
39963b3
fixing clang format issues
AsherGlick Aug 18, 2024
548e043
Merge pull request #332 from AsherGlick/proto-loading-category-fix
AsherGlick Aug 19, 2024
bbc1977
Removed unneeded comment and changed logic to unindent some lines
klingbolt Aug 22, 2024
cf51fdb
Merge pull request #319 from klingbolt/texture_id_search
AsherGlick Aug 22, 2024
543d09f
Renaming integration tests to prepare for more proto tests
AsherGlick Aug 22, 2024
b56e3b4
Changed import button to add new pack into existing packs instead of …
klingbolt Aug 29, 2024
d69db9a
clang formatting
klingbolt Aug 29, 2024
2723a49
Added globalize path to arguments
klingbolt Aug 29, 2024
8e826f8
Merge pull request #344 from klingbolt/single_marker_save_file
AsherGlick Sep 2, 2024
90e4f9c
Changed Default_toggle to hide_category in the proto
klingbolt Sep 5, 2024
7800c5b
Added integrations tests
klingbolt Sep 5, 2024
f72024f
Added tests for the proto input field hide_category
klingbolt Sep 5, 2024
352ce71
Changed name of variable in documentation and regenerated code
klingbolt Sep 5, 2024
86b8d20
Merge pull request #11 from klingbolt/xml_converter
klingbolt Sep 5, 2024
4237131
renamed to match new test format
klingbolt Sep 5, 2024
5322ee7
changed name to is_hidden
klingbolt Sep 8, 2024
335463d
Merge pull request #347 from klingbolt/invert_default_visibility
AsherGlick Sep 8, 2024
6cd4cb7
Change Scale On Map with Zoom to Constant Size on Map
klingbolt Sep 8, 2024
8c1e6f2
Edit description of Icon Size to clarify what the value does
klingbolt Sep 8, 2024
514f226
fixed grammar
klingbolt Sep 8, 2024
b740a38
Merge pull request #349 from klingbolt/clarify_icon_size
AsherGlick Sep 8, 2024
4de28d3
Merge pull request #348 from klingbolt/scale_on_map
AsherGlick Sep 9, 2024
b107b5d
Changed render in game to is_hidden_ingame
klingbolt Sep 10, 2024
0f328cc
reduced size of proto tests
klingbolt Sep 10, 2024
4c12c44
Changed render_on_map to _is_hidden_on_map
klingbolt Sep 11, 2024
93cb8eb
Changed render_on_minimap to is_hidden_on_minimap
klingbolt Sep 11, 2024
a087e5e
Fixed a bug that caused trails to not inherit attributes correctly
klingbolt Sep 11, 2024
7364bd8
Previous test worked by accident. Made an addition to a previous test…
klingbolt Sep 12, 2024
7e2596c
added tests for trail attributues
klingbolt Sep 12, 2024
2f823a7
added tests for trail attributues
klingbolt Sep 12, 2024
ec2f2e9
added tests for trail attributues
klingbolt Sep 12, 2024
af9c800
Merge pull request #350 from klingbolt/invert_render_ingame
AsherGlick Sep 14, 2024
b8f1bd3
Merge branch 'xml_converter' into render_on_map
klingbolt Sep 19, 2024
1c95171
Merge pull request #351 from klingbolt/render_on_map
AsherGlick Sep 19, 2024
c485339
Merge branch 'xml_converter' into invert_render_on_minimap
klingbolt Sep 19, 2024
77f2d6f
Merge pull request #352 from klingbolt/invert_render_on_minimap
AsherGlick Sep 19, 2024
631ba3c
Rearranged test to make trail inheritance a seperate category
klingbolt Sep 19, 2024
f7bcbd0
Merge pull request #12 from klingbolt/xml_converter
klingbolt Sep 19, 2024
919b550
Changed the name waypoint to guildpoint
klingbolt Sep 22, 2024
cd209d5
clang formating
klingbolt Sep 22, 2024
2b6308b
Merge pull request #353 from klingbolt/trail_inheritance_bug
AsherGlick Sep 22, 2024
4637b96
Merge pull request #356 from klingbolt/guildpoint_over_waypoint
AsherGlick Sep 22, 2024
0c37c45
Merged changes in master into xml_converter
klingbolt Oct 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
92 changes: 92 additions & 0 deletions .github/workflows/diff_protobin.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
name: Diff Protobin

on:
pull_request_target:
paths:
- '**/*.bin'
jobs:
custom-diff:
runs-on: ubuntu-latest
if: '!github.event.pull_request.draft'
permissions: write-all
steps:
- name: Checkout Code
uses: actions/checkout@v2

- name: Install ProtoC
run: sudo apt-get install -y protobuf-compiler

- name: Fetch PR commits
run: |
git fetch origin +refs/pull/${{ github.event.pull_request.number }}/head:refs/pull/${{ github.event.pull_request.number }}/head
git fetch origin ${{ github.base_ref }}

- name: Get Filenames
run: |
for file in $(git diff --name-only origin/${{ github.base_ref }} refs/pull/${{ github.event.pull_request.number }}/head | grep '.bin$'); do
mkdir -p $(dirname "$file")
if [ -n "$(git ls-tree "origin/${{ github.base_ref }}" -- "$file")" ]; then
git show origin/${{ github.base_ref }}:$file > $file._old
protoc --decode=guildpoint.Guildpoint xml_converter/proto/guildpoint.proto < $file._old > $file.textproto._old
else
touch $file.textproto._old
fi

if [ -n "$(git ls-tree "refs/pull/${{ github.event.pull_request.number }}/head" -- "$file")" ]; then
git show refs/pull/${{ github.event.pull_request.number }}/head:$file > $file._new
protoc --decode=guildpoint.Guildpoint xml_converter/proto/guildpoint.proto < $file._new > $file.textproto._new
else
touch $file.textproto._new
fi

diff -u $file.textproto._old $file.textproto._new > $file._diff || true
echo $file >> file_list.txt
done

- name: Get PR commit hash
id: prcommithash
run: |
PR_COMMIT_HASH=$(git log --format="%H" -n 1 refs/pull/${{ github.event.pull_request.number }}/head)
echo "Latest PR Commit Hash: $PR_COMMIT_HASH"
echo "pr_commit_hash="$PR_COMMIT_HASH >> $GITHUB_OUTPUT

- name: Post Comment
if: always()
uses: actions/github-script@v7
with:
script: |
const fs = require('fs');
const path = require('path');

const issue_number = context.issue.number;
const githubToken = process.env.GITHUB_TOKEN;

const files = fs.readFileSync('file_list.txt', 'utf8').split("\n");

for (let file of files) {
if (file == "") {
continue;
}
const diff_contents = fs.readFileSync(file + "._diff", 'utf8')
let comment_body = [
"<details>",
"<summary>Full Diff</summary>",
"",
"```diff",
diff_contents,
"```",
"</details>",
].join("\n");

console.log(file)

await github.rest.pulls.createReviewComment({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: issue_number,
path: file,
body: comment_body,
commit_id: '${{ steps.prcommithash.outputs.pr_commit_hash }}',
subject_type: "file",
});
}
230 changes: 186 additions & 44 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# This workflow will compile the burrio_link and export the burrito binary
# the two files will be available as an artifact.
# This workflow will compile burrio_link.exe, the burrito binary, and any
# additional libraries needed to run. All these files will then be available
# as an artifact.

name: CI

Expand All @@ -25,16 +26,133 @@ on:
# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
# This workflow contains a single job called "build"
Build-Linux:
Build-XMLConverter-Linux:
# The type of runner that the job will run on
runs-on: ubuntu-20.04

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
- uses: actions/checkout@v2
- name: Checkout repository
uses: actions/checkout@v4

# - name: Update Packages
# run: sudo apt-get update && sudo apt-get upgrade
# IWYU is disabled for now due to noise. It will be re-enabled at a later date
# # `clang-9` must be installed here because of a weird unlisted dependency
# # on some sort of file that clang-9 installs. Without it iwyu would
# # complain about missing files and error out.
# - name: Install include-what-you-use
# run: |
# sudo apt-get install iwyu
# sudo apt-get install clang-9

- name: Install protoc
run: sudo apt-get install protobuf-compiler

- name: Install gtest
run: sudo apt-get install libgtest-dev

- name: Install cpplint
run: |
pip3 install cpplint

- name: Install xml_converter python Dependencies
run: |
cd xml_converter
python3 -m venv venv
source venv/bin/activate
pip install -r requirements.txt

- name: Build xml_converter
run: |
cd xml_converter
mkdir -v -p build
cd build
cmake ..
make

- name: Validate xml_converter
run: |
cd xml_converter
cp build/compile_commands.json ./compile_commands.json
./presubmit.sh

- name: Upload created file
uses: actions/upload-artifact@v3
with:
name: xml_converter
path: xml_converter/build/xml_converter
if-no-files-found: error

Build-BurritoLink-Linux:
runs-on: ubuntu-20.04
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Install mingw
run: sudo apt-get install gcc-mingw-w64

- name: Build Burrito Link
run: |
mkdir burrito_link/build
cd burrito_link/build
cmake ..
make

- name: Upload Standalone Executable Burrito Link
uses: actions/upload-artifact@v3
with:
name: burrito_link_exe
path: burrito_link/build/burrito_link.exe
if-no-files-found: error

- name: Upload Shared Library Burrito Link
uses: actions/upload-artifact@v3
with:
name: burrito_link_dll
path: burrito_link/build/d3d11.dll
if-no-files-found: error

Build-BurritoFG-Linux:
runs-on: ubuntu-20.04
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Build X11_FG
run: |
cd burrito-fg
cargo build --release

- name: Upload created file
uses: actions/upload-artifact@v3
with:
name: BurritoFG
path: burrito-fg/target/release/libburrito_fg.so
if-no-files-found: error

Build-TacoParser-Linux:
runs-on: ubuntu-20.04
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Build taco_parser
run: |
cd taco_parser
cargo build --release

- name: Upload created file
uses: actions/upload-artifact@v3
with:
name: TacoParser
path: taco_parser/target/release/libgw2_taco_parser.so
if-no-files-found: error

Build-BurritoUI-Linux:
runs-on: ubuntu-20.04
steps:
- name: Checkout repository
uses: actions/checkout@v4

# - name: Cache Godot
# id: cache-godot
Expand All @@ -43,14 +161,15 @@ jobs:
# path: ./Godot_v${GODOT_VERSION}-stable_linux_headless.64
# key: ${{ runner.os }}-godot-${GODOT_VERSION}-${CACHE_STRING}

#

- name: Download Godot
# if: steps.cache-godot.outputs.cache-hit != 'true'
run: |
wget -q https://downloads.tuxfamily.org/godotengine/${GODOT_VERSION}/Godot_v${GODOT_VERSION}-stable_linux_headless.64.zip
wget -q https://github.com/godotengine/godot/releases/download/${GODOT_VERSION}-stable/Godot_v${GODOT_VERSION}-stable_linux_headless.64.zip
unzip Godot_v${GODOT_VERSION}-stable_linux_headless.64.zip
rm Godot_v${GODOT_VERSION}-stable_linux_headless.64.zip


# - name: Cache Godot Templates
# id: cache-godot-templates
# uses: actions/cache@v2
Expand All @@ -64,59 +183,82 @@ jobs:
run: |
mkdir -v -p ~/.local/share/godot/templates/${GODOT_VERSION}.stable/

wget -q https://downloads.tuxfamily.org/godotengine/${GODOT_VERSION}/Godot_v${GODOT_VERSION}-stable_export_templates.tpz
wget -q https://github.com/godotengine/godot/releases/download/${GODOT_VERSION}-stable/Godot_v${GODOT_VERSION}-stable_export_templates.tpz

unzip Godot_v${GODOT_VERSION}-stable_export_templates.tpz
mv templates/* ~/.local/share/godot/templates/${GODOT_VERSION}.stable/
ls ~/.local/share/godot/templates/${GODOT_VERSION}.stable/

- name: Fake The GDNative Files
run: |
mkdir -p burrito-fg/target/release/
touch burrito-fg/target/release/libburrito_fg.so
mkdir -p taco_parser/target/release/
touch taco_parser/target/release/libgw2_taco_parser.so

- name: Install mingw
run: sudo apt-get install gcc-mingw-w64
- name: Build Burrito
run: |
mkdir -v -p build
./Godot_v${GODOT_VERSION}-stable_linux_headless.64 --export "Linux/X11"
chmod +x build/burrito.x86_64

- uses: actions/upload-artifact@v3
with:
name: Burrito_UI
path: build/burrito.x86_64
if-no-files-found: error

# Runs a single command using the runners shell
- name: Create the Output Directory
run: mkdir output

- name: Build X11_FG
run: |
cd burrito-fg
cargo build --release
Package-Burrito-Linux:
runs-on: ubuntu-20.04
needs:
- Build-XMLConverter-Linux
- Build-BurritoLink-Linux
- Build-BurritoUI-Linux
- Build-BurritoFG-Linux
- Build-TacoParser-Linux
steps:
- name: Download Burrito UI
uses: actions/download-artifact@v3
with:
name: Burrito_UI

- name: Build taco_parser
run: |
cd taco_parser
cargo build --release
- name: Download Burrito FG
uses: actions/download-artifact@v3
with:
name: BurritoFG

- name: Build Burrito Link
run: |
mkdir output/burrito_link
mkdir burrito_link/build
cd burrito_link/build
cmake ..
make
mv burrito_link.exe ../../output/burrito_link
mv d3d11.dll ../../output/burrito_link
- name: Download TacoParser
uses: actions/download-artifact@v3
with:
name: TacoParser

- name: Download XML Converter
uses: actions/download-artifact@v3
with:
name: xml_converter

- name: Download Burrito Link Exe
uses: actions/download-artifact@v3
with:
name: burrito_link_exe

- name: Download Burrito Link DLL
uses: actions/download-artifact@v3
with:
name: burrito_link_dll

- name: Build Burrito
run: |
mkdir build
./Godot_v${GODOT_VERSION}-stable_linux_headless.64 --export "Linux/X11"
chmod +x build/burrito.x86_64
mv build/burrito.x86_64 output/
mv build/libburrito_fg.so output/
mv build/libgw2_taco_parser.so output/

- name: Move Burrito Link
run: |
mkdir burrito_link/
mv burrito_link.exe burrito_link/
mv d3d11.dll burrito_link/

- uses: actions/upload-artifact@v2.2.4
- uses: actions/upload-artifact@v3
with:
# Artifact name
name: "Burrito_Linux" # optional, default is artifact
# A file, directory or wildcard pattern that describes what to upload
path: "output/*"
path: "./*"
# The desired behavior if no files are found using the provided path.
if-no-files-found: error
# Duration after which artifact will expire in days. 0 means using default retention.
retention-days: 0
18 changes: 18 additions & 0 deletions Category2D.gd
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
extends Node2D

var trails2d: Array = []
var subcategories: Array = []

func add_trail2d(trail2d):
self.add_child(trail2d, true)
trails2d.push_back(trail2d)

func add_subcategory(subcategory):
self.add_child(subcategory, true)
subcategories.push_back(subcategory)

func clear_all():
self.trails2d = []
self.subcategories = []
for child in self.get_children():
child.queue_free()
Loading
Loading