Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetAddressUtxos regex for R-addresses #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

who-biz
Copy link

@who-biz who-biz commented Jul 20, 2024

GetAddressUtxos regex check was validating 35-character t-addresses from ZEC. Verus R-addresses are only 34 characters.

Prior to change, calling the following:

grpcurl -d '{ "addresses": ["<R-address>"] }' lwdlegacy.blur.cash:443 cash.z.wallet.sdk.rpc.CompactTxStreamer/GetAddressUtxos

(lwdlegacy.blur.cash has been updated, so you will need to use lightwallet.verus.services:8120, to verify error)

Results in Invalid Address error:

error="Invalid address" method=/cash.z.wallet.sdk.rpc.CompactTxStreamer/GetAddressUtxos peer_addr="127.0.0.1:55740"

Above is printed to stderr if --grpc-logging-insecure flag is toggled


After this change, valid information is returned in gRPC response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant