Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extract Originator into a base abstract #32

Merged
merged 2 commits into from
Oct 18, 2023
Merged

feat: extract Originator into a base abstract #32

merged 2 commits into from
Oct 18, 2023

Conversation

dangerousfood
Copy link
Contributor

  • Took the key interface pieces and moved them into Originator
  • UniqueOriginator and what was Originator were combined into StrategistOriginator
  • PoolOriginator deleted
  • Tests and imports updated

@androolloyd
Copy link
Contributor

We will need the conflicts resolved, likely from the directory re structuring, but otherwise looks fine.

@androolloyd
Copy link
Contributor

once you update be sure to generate a new gas snapshot too.

@dangerousfood dangerousfood merged commit 1b59637 into main Oct 18, 2023
@justingreenberg justingreenberg deleted the feat/originator branch November 20, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xgregthedev 0xgregthedev 0xgregthedev approved these changes

@androolloyd androolloyd Awaiting requested review from androolloyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dangerousfood @androolloyd @0xgregthedev