Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/loanmanager testing #33

Closed
wants to merge 8 commits into from
Closed

feat/loanmanager testing #33

wants to merge 8 commits into from

Conversation

androolloyd
Copy link
Contributor

  • Coverage testing for loan manager, wip
  • updates to refinance and a test to validate its cheaper

@androolloyd
Copy link
Contributor Author

Ok, refinance has been reworked, lots of asserts added to previewOrder return values, will do some more along the way but this is good now for a review and merge.

Line Coverage on the LM is at 96% with 100% of the functions being called in tests, Branch coverage at 70%, a little more work to do there but for now LGTM

@0xgregthedev BROTHER ITS LIFTING TIME

@androolloyd
Copy link
Contributor Author

LM is 100/100 and Branch coverage is at 80%, unsure where the other branches truly lie

@justingreenberg justingreenberg deleted the feat/loanmanager-testing branch November 20, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xgregthedev 0xgregthedev 0xgregthedev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@androolloyd @0xgregthedev