feat/AST 1952 v1 handler testing #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
androolloyd
commented
Nov 2, 2023
androolloyd
commented
- update getAuctionStart to be a public helper, make an internal version that is more optimized(less calls/decoding), add tests
- coverage testing for AstariaV1Settlement handler complete
- coverage testing for AstariaV1Settlement handler complete
- Feat/repay test (Feat/repay test #40)
- fix test name
- Astaria V1 Hook testing complete(-withdraw), Conduit Helper Removed, ConduitTransfer => AdditionalTransfer
…n that is more optimized(less calls/decoding), add tests
…952-v1-handler-testing
…ConduitTransfer => AdditionalTransfer
dangerousfood
approved these changes
Nov 2, 2023
0xgregthedev
pushed a commit
that referenced
this pull request
Nov 2, 2023
* update getAuctionStart to be a public helper, make an internal version that is more optimized(less calls/decoding), add tests * coverage testing for AstariaV1Settlement handler complete * coverage testing for AstariaV1Settlement handler complete * fix test name * Astaria V1 Hook testing complete(-withdraw), Conduit Helper Removed, ConduitTransfer => AdditionalTransfer * remove commented code * final comment removal
androolloyd
added a commit
that referenced
this pull request
Nov 3, 2023
* WIP * Feat/ast 1952 v1 handler testing (#41) * update getAuctionStart to be a public helper, make an internal version that is more optimized(less calls/decoding), add tests * coverage testing for AstariaV1Settlement handler complete * coverage testing for AstariaV1Settlement handler complete * fix test name * feat/AST 1952 v1 handler testing (#43) * update getAuctionStart to be a public helper, make an internal version that is more optimized(less calls/decoding), add tests * coverage testing for AstariaV1Settlement handler complete * coverage testing for AstariaV1Settlement handler complete * fix test name * Astaria V1 Hook testing complete(-withdraw), Conduit Helper Removed, ConduitTransfer => AdditionalTransfer * remove commented code * final comment removal * feat/V1 hook updates (#44) * update getAuctionStart to be a public helper, make an internal version that is more optimized(less calls/decoding), add tests * coverage testing for AstariaV1Settlement handler complete * coverage testing for AstariaV1Settlement handler complete * fix test name * Astaria V1 Hook testing complete(-withdraw), Conduit Helper Removed, ConduitTransfer => AdditionalTransfer * remove commented code * final comment removal * additional tests for v1 hook as well as some cleanup/fixes * update snaphot * working caveat testing and reentrancy guard * remove ownable and change loan.issuer to lender --------- Co-authored-by: androolloyd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.