Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/V1 hook updates #44

Merged
merged 12 commits into from
Nov 2, 2023
Merged

feat/V1 hook updates #44

merged 12 commits into from
Nov 2, 2023

Conversation

androolloyd
Copy link
Contributor

  • update getAuctionStart to be a public helper, make an internal version that is more optimized(less calls/decoding), add tests
  • coverage testing for AstariaV1Settlement handler complete
  • coverage testing for AstariaV1Settlement handler complete
  • Feat/repay test (Feat/repay test #40)
  • fix test name
  • Feat/ast 1952 v1 handler testing (Feat/ast 1952 v1 handler testing #41)
  • Astaria V1 Hook testing complete(-withdraw), Conduit Helper Removed, ConduitTransfer => AdditionalTransfer
  • remove commented code
  • final comment removal
  • additional tests for v1 hook as well as some cleanup/fixes

@dangerousfood dangerousfood merged commit 90411a2 into main Nov 2, 2023
1 check passed
0xgregthedev pushed a commit that referenced this pull request Nov 2, 2023
@androolloyd @0xgregthedev
feat/V1 hook updates (#44)
97e6932 
* update getAuctionStart to be a public helper, make an internal version that is more optimized(less calls/decoding), add tests

* coverage testing for AstariaV1Settlement handler complete

* coverage testing for AstariaV1Settlement handler complete

* fix test name

* Astaria V1 Hook testing complete(-withdraw), Conduit Helper Removed, ConduitTransfer => AdditionalTransfer

* remove commented code

* final comment removal

* additional tests for v1 hook as well as some cleanup/fixes

* update snaphot
androolloyd added a commit that referenced this pull request Nov 3, 2023
@0xgregthedev @androolloyd
Feat/caveat test rebase (#46)
675328b 
* WIP

* Feat/ast 1952 v1 handler testing (#41)

* update getAuctionStart to be a public helper, make an internal version that is more optimized(less calls/decoding), add tests

* coverage testing for AstariaV1Settlement handler complete

* coverage testing for AstariaV1Settlement handler complete

* fix test name

* feat/AST 1952 v1 handler testing (#43)

* update getAuctionStart to be a public helper, make an internal version that is more optimized(less calls/decoding), add tests

* coverage testing for AstariaV1Settlement handler complete

* coverage testing for AstariaV1Settlement handler complete

* fix test name

* Astaria V1 Hook testing complete(-withdraw), Conduit Helper Removed, ConduitTransfer => AdditionalTransfer

* remove commented code

* final comment removal

* feat/V1 hook updates (#44)

* update getAuctionStart to be a public helper, make an internal version that is more optimized(less calls/decoding), add tests

* coverage testing for AstariaV1Settlement handler complete

* coverage testing for AstariaV1Settlement handler complete

* fix test name

* Astaria V1 Hook testing complete(-withdraw), Conduit Helper Removed, ConduitTransfer => AdditionalTransfer

* remove commented code

* final comment removal

* additional tests for v1 hook as well as some cleanup/fixes

* update snaphot

* working caveat testing and reentrancy guard

* remove ownable and change loan.issuer to lender

---------

Co-authored-by: androolloyd <[email protected]>
@justingreenberg justingreenberg deleted the feat/V1-hook-updates branch November 20, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangerousfood dangerousfood dangerousfood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@androolloyd @dangerousfood