Feat/caveat test rebase #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update getAuctionStart to be a public helper, make an internal version that is more optimized(less calls/decoding), add tests * coverage testing for AstariaV1Settlement handler complete * coverage testing for AstariaV1Settlement handler complete * fix test name
* update getAuctionStart to be a public helper, make an internal version that is more optimized(less calls/decoding), add tests * coverage testing for AstariaV1Settlement handler complete * coverage testing for AstariaV1Settlement handler complete * fix test name * Astaria V1 Hook testing complete(-withdraw), Conduit Helper Removed, ConduitTransfer => AdditionalTransfer * remove commented code * final comment removal
* update getAuctionStart to be a public helper, make an internal version that is more optimized(less calls/decoding), add tests * coverage testing for AstariaV1Settlement handler complete * coverage testing for AstariaV1Settlement handler complete * fix test name * Astaria V1 Hook testing complete(-withdraw), Conduit Helper Removed, ConduitTransfer => AdditionalTransfer * remove commented code * final comment removal * additional tests for v1 hook as well as some cleanup/fixes * update snaphot
0xgregthedev
force-pushed
the
feat/caveat-test-rebase
branch
from
c453fe7 to
b70045a
Compare
androolloyd
reviewed
Nov 3, 2023
androolloyd
reviewed
Nov 3, 2023
| @@ -469,6 +453,14 @@ contract LoanManager is Ownable, ERC721 { | |||
| ); | |||
| } | |||
|
|
|||
| function incrementCaveatNonce() external { | |||
| ++caveatNonces[msg.sender]; | |||
There was a problem hiding this comment.
in my change i did the seaport style nonce increment, but unsure if we care, also we need an event to both so that we can index them/invalidte things
There was a problem hiding this comment.
Seaport style sounds good to me. Yeah probably should add the salt event to validateSalt as well
There was a problem hiding this comment.
ok can just adopt my methods then they have events and the seaport style nonce update, will add events to the invalidate caveat salt
androolloyd
reviewed
Nov 3, 2023
0xgregthedev
force-pushed
the
feat/caveat-test-rebase
branch
from
fd33e72 to
114cce4
Compare
androolloyd
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.