feat/exotic repayment settlement tests #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
androolloyd
commented
Nov 20, 2023
androolloyd
commented
- update for simple interest pricing to ensure old and new decimals are the same, update _settleLoan helper, add exotic repayment/settlement testing with custom pricing and settlement modules
- update fuzzers with random erc20 and decimals, update applyRefinanceConsideration to just override the debt based on incoming payment data from getRefinanceConsideration
… the same, update _settleLoan helper, add exotic repayment/settlement testing with custom pricing and settlement modules
…onsideration to just override the debt based on incoming payment data from getRefinanceConsideration
…feat/exotic-repayment-settlement-tests
dangerousfood
approved these changes
Nov 20, 2023
…ceConsiderationToLoan method accessing memory directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.