-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump cosmos-sdk v0.46 and evmos v12 #209
Conversation
|
||
for _, val := range valSet.Validators { | ||
pk, _ := cryptocodec.FromTmPubKeyInterface(val.PubKey) | ||
pkAny, _ := codectypes.NewAnyWithValue(pk) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
bondAmt := sdk.DefaultPowerReduction | ||
|
||
for _, val := range valSet.Validators { | ||
pk, _ := cryptocodec.FromTmPubKeyInterface(val.PubKey) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
@@ -60,17 +66,28 @@ | |||
isCheckTx bool, | |||
feemarketGenesis *feemarkettypes.GenesisState, | |||
) *Astra { | |||
privVal := mock.NewPV() | |||
pubKey, _ := privVal.GetPubKey() |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
Protobuf breakage is expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Features
--grpc
client option.--append
flag to thesign-batch
CLI cmd to combine the messages and sign those txs which are created with--generate-only
.sign-batch
CLI can now read multiple transaction files.List()
function.tx group draft-proposal
command for generating group proposal JSONs (skeleton).tx gov draft-proposal
command for generating proposal JSONs (skeleton).prune
CLI cmd to manually prune app store history versions based on the pruning options.tx auth multi-sign
as alias oftx auth multisign
for consistency withmulti-send
.tx bank multi-send
command for bulk send of coins to multiple accounts.inspect
command to thetendermint
sub-command./cosmos/base/node/v1beta1/config
, which provides operator configuration.app.toml
. Seemax-recv-msg-size
andmax-send-msg-size
respectively.ABCIQuery
in the Tendermint gRPC service, which proxies ABCIQuery
requests directly to the application.ScheduleUpgrade
for chains to schedule an automated upgrade onBeginBlock
without having to go though governance.MsgSoftwareUpgrade
andMsgCancelUpgrade
have been added to support v1beta2 msgs-based gov proposals.Improvements
v0.34.29
with several minor bug fixes and low-severity security-fixes.rootmulti.Store.CacheMultiStoreWithVersion
now can handle loading archival states that don't persist any of the module stores the current state has.store/v2alpha1
.rootmulti.Store.loadVersion
has validation to check if all the module stores' height is correct, it will error if any module store has incorrect height.iavl-lazy-loading
to enable lazy loading of iavl store, to improve start up time of archive nodes, add methodSetLazyLoading
toCommitMultiStore
interface.v1.Proposal
message inv1beta1.Proposal.Content
.Close
method toBaseApp
for custom app to cleanup resource in graceful shutdown.CommitMultiStore
.AppStateFnWithExtendedCb
with callback function to extend rawState andAppStateRandomizedFnWithState
with extra genesisState argument which is the genesis state of the app.GasConfig
configuration for applications.Bug Fixes
client.ValidatePromptAddress
.LatestBlockResponse
&BlockByHeightResponse
types' fieldsdk_block
was incorrectly castproposer_address
bytes to validator operator address, now to consensus address._
characters in tx event queries, i.e.GetTxsEvent
.State Machine Breaking
govv046.Migrate_V0466_To_V0467
for migrating a chain already on v0.46 with versions <=v0.46.6 to the latest v0.46.7 correct state.x/gov
ModuleAccountInvariant
invariant to ensure deposits are<=
total module account balance instead of strictly equal.CancelUnbondingDelegation
transaction to
x/staking
module. Delegators can now cancel unbonding delegation entry and delegate back to validator.evm
andfeemarket
typesMsgUpdateVestingFunder
that updates theFunder
field of a given clawback vesting accountAPI Breaking
RollbackToVersion
to interfaceCommitMultiStore
and added methodCommitMultiStore
toApplication
interface.NewRollbackCmd
now takes anappCreator types.AppCreator
.Migrate_V046_6_To_V046_7
function which shouldn't be used for chains which already migrated to 0.46.x/gov
api tov1beta1
directory.x/gov/types
tox/gov/types/v1beta2
.ListenCommit
toABCIListener
ListeningEnabled
andAddListener
methods toCommitMultiStore
CacheWrapWithListeners
fromCacheWrap
andCacheWrapper
interfacesrootmulti.Store
)ABCIListener
such that any error from any method will always halt the app viapanic
LatestVersion
toMultiStore
interface, add methodSetQueryMultiStore
to baesapp to support alternativeMultiStore
implementation for query service.MempoolFeeDecorator
has been removed. Instead, theDeductFeeDecorator
takes a new argument of typeTxFeeChecker
, to define custom fee models. Ifnil
is passed to thisTxFeeChecker
argument, then it will default tocheckTxFeeWithValidatorMinGasPrices
, which is the exact same behavior as the oldMempoolFeeDecorator
(i.e. checking fees against validator's own min gas price).ExtensionOptionsDecorator
takes an argument of typeExtensionOptionChecker
. For backwards-compatibility, you can passnil
, which defaults to the old behavior of rejecting all tx extensions.Unsafe*
interfaces from keyring package. Please use interface casting if you wish to access those unsafe functions.AccAddressFromHex
toAccAddressFromHexUnsafe
.Int
andUint
types have been moved to their own dedicated module,math
. Aliases are kept in the SDK's roottypes
package, however, it is encouraged to utilize the newmath
module. As a result, theInt#ToDec
API has been removed.Coins#Sub
andCoins#SafeSub
consistent withCoins#Add
.Info
(serialized as amino) ->Record
(serialized as proto)codec.Codec
argument in:keyring.NewInMemory
keyring.New
SavePubKey
toSaveOfflineKey
.NewMultiInfo
,NewLedgerInfo
toNewLegacyMultiInfo
,newLegacyLedgerInfo
respectively. Move them intolegacy_info.go
.NewOfflineInfo
tonewLegacyOfflineInfo
and move it tomigration_test.go
.*
keyring.Record, error
inSaveOfflineKey
,SaveLedgerKey
,SaveMultiSig
,Key
andKeyByAddress
.*
keyring.Record
instead ofInfo
inNewMnemonic
andList
.algo
argument from :SaveOfflineKey
keyring.Record
instead ofInfo
as first argument in:MkConsKeyOutput
MkValKeyOutput
MkAccKeyOutput
clientCtx.JSONCodec
fromclient.Context
.EncodingConfig.Marshaler
toCodec
.RESTHandlerFn
argument is removed from thegov/NewProposalHandler
.types/rest
package moved totestutil/rest
.