-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript)!: replace typescript-tools
with vtsls
#969
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
@rafaelderolez @owittek @RayJameson What do you guys think? |
I don't code TS/JS, so I can't contribute to this discussion |
#974 is proof that this is the way. |
typescript-tools
with vtsls
typescript-tools
with vtsls
not a fan of typescript-tools so feel free to go ahead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Yeah I second this. Lets go ahead and merge this @mehalter . Typescript-tools is just a pain in the ass at this point. |
after updating I can't see inlay hints anymore. Am I missing something? |
Hm I thought I configured vtsls with the same inlay hints 🤔 like you don't see them when you toggle them on or you have turned them on by default in AstroLSP? I can check in a bit |
Make sure to uninstall tsserver... |
It worked correctly after a clean install. Thanks! |
Not sure how but it worked when I installed Thank you. |
hi mehalter, may I ask how to uninstall tsserver / ts_ls ? I am new to AstroNvim |
I cleaned the neovim folder and this works for me LOL |
📑 Description
This moves from
typescript-tools.nvim
tovtsls
language server. Let me know if this is desired, I feel liketypescript-tools
always has problems with usersℹ Additional Information