Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript)!: replace typescript-tools with vtsls #969

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

mehalter
Copy link
Member

📑 Description

This moves from typescript-tools.nvim to vtsls language server. Let me know if this is desired, I feel like typescript-tools always has problems with users

ℹ Additional Information

Copy link

github-actions bot commented May 16, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft
Copy link
Member

Uzaaft commented May 16, 2024

@rafaelderolez @owittek @RayJameson What do you guys think?

@RayJameson
Copy link
Contributor

I don't code TS/JS, so I can't contribute to this discussion

@Uzaaft
Copy link
Member

Uzaaft commented May 23, 2024

#974 is proof that this is the way.

@mehalter mehalter changed the title feat!(typescript): replace typescript-tools with vtsls feat(typescript)!: replace typescript-tools with vtsls May 23, 2024
@owittek
Copy link
Member

owittek commented May 23, 2024

not a fan of typescript-tools so feel free to go ahead

Copy link
Member

@owittek owittek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Uzaaft
Copy link
Member

Uzaaft commented May 24, 2024

Yeah I second this. Lets go ahead and merge this @mehalter . Typescript-tools is just a pain in the ass at this point.

@mehalter mehalter merged commit 300a8c6 into main May 24, 2024
12 checks passed
@mehalter mehalter deleted the vtsls branch May 24, 2024 11:33
@ishwar00
Copy link

after updating I can't see inlay hints anymore. Am I missing something?

@mehalter
Copy link
Member Author

Hm I thought I configured vtsls with the same inlay hints 🤔 like you don't see them when you toggle them on or you have turned them on by default in AstroLSP? I can check in a bit

@gabrielscaranello
Copy link
Contributor

After the update, cmp and code actions options are duplicated.

image
image

@mehalter
Copy link
Member Author

Make sure to uninstall tsserver...

@gabrielscaranello
Copy link
Contributor

Make sure to uninstall tsserver...

It worked correctly after a clean install. Thanks!

@ishwar00
Copy link

Not sure how but it worked when I installed vtsls through Mason.

Thank you.

@ChrisShen93
Copy link

Make sure to uninstall tsserver...

hi mehalter, may I ask how to uninstall tsserver / ts_ls ? I am new to AstroNvim

@ChrisShen93
Copy link

Make sure to uninstall tsserver...

hi mehalter, may I ask how to uninstall tsserver / ts_ls ? I am new to AstroNvim

I cleaned the neovim folder and this works for me LOL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants