Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseGameInitialKnownItemList backwards compatibility hotfix #23

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

atenfyr
Copy link
Contributor

@atenfyr atenfyr commented Dec 6, 2024

This pull request modifies the mod integrator to copy all /Game/Items/ItemTypes/MasterItemList item list entries to also be integrated into /Game/Items/ItemTypes/BaseGameInitialKnownItemList, if a given mod does not explicitly specify entries for /Game/Items/ItemTypes/BaseGameInitialKnownItemList already.

Without this change, any mod that does not explicitly add any given new item into the /Game/Items/ItemTypes/BaseGameInitialKnownItemList list will not have that item visible in the research catalog on new saves, as it will not be considered a "known item." My understanding is that this is a relatively new and unknown issue. So, this hotfix is necessary to ensure that nearly every single current mod that currently adds items to the game is compatible with the latest version of the game. This hotfix also rectifies the issue for any pre-existing saves that may currently suffer from this issue.

While, strictly speaking, mod authors should simply be required to update their mods to be compatible for the latest version, the sudden and unexpected discontinuation of the astroneermods.space website means that it seems that many mods that were previously available on the website are as of yet not actively maintained. While I have considered simply privately modifying the metadata for the mods on my own archive of the website to rectify this issue (https://atenfyr.com/ams-archive/), I am hesitant to make precedent of this, as I am more interested in historical preservation than I am in personally actively maintaining the mods. So, this hot-fix allows existing mods to work on the latest version without maintenance for a little extra time, until such time that they may be maintained again, if ever.

@konsti219 konsti219 merged commit 7a00fc7 into AstroTechies:main Dec 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants