Removed try-catch from script, add regex to replace newline #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need feedback on 753c104 in order to change how to handle exceptions in such cases. |
Open
|
Requesting review from @Gummibeer to merge this asap |
|
I think that's no longer needed as of latest |
|
There's a new release: https://github.com/Astrotomic/php-deepface/releases/tag/0.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last pull request (#14) introduced a serious problem when running any script in a single line (python won't run a script with a try-except block in a single line because indentations, see #15 for more details).
Also, running the package on a linux-based server throws an error related with newline not being replaced correctly.
This PR should address all of this.