Don't regenerate regexp string on every call #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of current,
regexp()
in EmojiText creates a string from scratch on *every single call*. Since the method is invoked on every replace call, it results in a massive performance penalty when doing a lot of replace operations. This PR makes it so the string gets initialized once and reused on subsequent calls, resulting in as much as a 5-6x speedup on my machine.Below is a simple test case. I chose to perform 500k replacements to exacerbate the difference, but even in a real application context the difference was still quite pronounced doing as little as 5k replacements on short to moderate length strings.
Before the patch:
After the patch: