Add DLC Close message type #86
Conversation
dillionverma
force-pushed
the
dlc-close
branch
from
4126e68
to
91a7222
Compare
| @@ -222,26 +224,22 @@ describe('dlc provider', () => { | |||
| }); | |||
|
|
|||
| it('close', async () => { | |||
There was a problem hiding this comment.
We should probably add a test for passing in fixedInputs to createDlcClose
There was a problem hiding this comment.
Would be good to have a test for error cases, such as finalizeDlcClose with dlcClose that has invalid fundingInputs or invalid closeSignature
There was a problem hiding this comment.
Good idea, updated tests to reflect that
| } | ||
|
|
||
| return psbt; | ||
| psbt.validateSignaturesOfAllInputs(); |
There was a problem hiding this comment.
Might be good to have specific error for which input signature caused the psbt validation to fail
There was a problem hiding this comment.
This would automatically throw with that right?
There was a problem hiding this comment.
Yea this is something we can probably add later. Would just be nice to be able to see specific errors if close signature or funding inputs signatures were incorrect.
Use the new DLC Close message type from AtomicFinance/node-dlc#122