Skip to content

Commit

Permalink
AMP-3122
Browse files Browse the repository at this point in the history
- fix v-model compiler error for vue3
- replace vue-mediaelement with vue3 version
  • Loading branch information
yingfeng-iu committed Aug 20, 2024
1 parent ab9ed7b commit ef1cde8
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"underscore": "^1.13.7",
"vue": "^3.4.34",
"vue-click-outside": "^1.1.0",
"vue-mediaelement": "^1.0.0",
"vue3-mediaelement": "^0.0.8",
"vue-router": "^4.4.0",
"vuejs3-datepicker": "^1.0.19",
"vuera": "^0.2.7",
Expand Down
2 changes: 1 addition & 1 deletion src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import Sidebar from "@/components/navigation/Sidebar.vue";
import config from "./assets/constants/common-contant.js";
import { env } from "@/helpers/env.js";
import "vue-mediaelement/src";
import "vue3-mediaelement/src";
export default {
components: {
Sidebar,
Expand Down
2 changes: 0 additions & 2 deletions src/components/entity/Mediaelement.vue
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
</template>

<script>
// import "mediaelement";
// import "vue-mediaelement/src";
export default {
name: "Mediaelement",
props: {
Expand Down
3 changes: 2 additions & 1 deletion src/components/evaluation/GroundTruthModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
<div>
<loader :show="loading" />
<b-modal
v-model="showModal"
:modelValue="showModal"
@update:modelValue="showModal = $event"
id="modal-center"
centered
no-close-on-backdrop
Expand Down

0 comments on commit ef1cde8

Please sign in to comment.