Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP-2880 #507

Closed
wants to merge 2 commits into from
Closed

AMP-2880 #507

wants to merge 2 commits into from

Conversation

yingfeng-iu
Copy link
Collaborator

@yingfeng-iu yingfeng-iu commented Apr 17, 2024

update: we're trying to upgrade to latest Node 22. this PR can wait on AMP-3157.
updates: more fixes in PR now. ready to merge once Node is upgraded for Test

  • package.json: upgrade dependencies to latest within the limit of compatibility with current Vue 2 version, while supported by upgraded Node version
  • tmp fix for css related errors (as mentioned in AMP-1811)
  • temporarily surppress eslint errors to allow compilation (upgraded eslint has stricter requirements that would break current code)
  • rename Header to AmpHeader as required by eslint
  • tmp removal of bbs editor related code to allow compilation

- package.json: upgrade dependencies to latest within the limit of
compatibility with current Vue 2 version, while supported by upgraded
Node version
- tmp fix for css related errors (as mentioned in AMP-1811)
- temporarily surppress eslint errors to allow compilation (upgraded
eslint has stricter requirements that would break current code)
- rename Header to AmpHeader as required by eslint
- tmp removal of bbs editor related code to allow compilation
- fix container col (for homepage and all components using container
col-12)
- fix filter buttons
@yingfeng-iu
Copy link
Collaborator Author

this PR is replaced with new PR for AMP-3157 with further changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant