Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amp 3157 node22 #508

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Amp 3157 node22 #508

merged 5 commits into from
Apr 25, 2024

Conversation

yingfeng-iu
Copy link
Collaborator

@yingfeng-iu yingfeng-iu commented Apr 25, 2024

This PR replaces PR for AMP-2880 and will be ready to merge once Node 22 is installed on liger

- package.json: upgrade dependencies to latest within the limit of
compatibility with current Vue 2 version, while supported by upgraded
Node version
- tmp fix for css related errors (as mentioned in AMP-1811)
- temporarily surppress eslint errors to allow compilation (upgraded
eslint has stricter requirements that would break current code)
- rename Header to AmpHeader as required by eslint
- tmp removal of bbs editor related code to allow compilation
- fix container col (for homepage and all components using container
col-12)
- fix filter buttons
- switch from node-sass to sass with latest version
@yingfeng-iu yingfeng-iu requested a review from bdwheele April 25, 2024 16:26
package. once we are ready for release, we can update to 2.0.0 for all
packages
@yingfeng-iu yingfeng-iu merged commit 5d36939 into master Apr 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant