Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate TextShouts from other kinds of content #2

Merged
merged 2 commits into from
Mar 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/controllers/shouts_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ def show
private

def shout_params
{ content: content_from_params }
end

def content_from_params
TextShout.new(content_params)
end

def content_params
params.require(:shout).permit(:body)
end

Expand Down
2 changes: 1 addition & 1 deletion app/models/shout.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
class Shout < ApplicationRecord
belongs_to :user
belongs_to :content, polymorphic: true

validates :body, presence: true, length: { in: 1..144 }
validates :user, presence: true

delegate :username, to: :user
Expand Down
3 changes: 3 additions & 0 deletions app/models/text_shout.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
class TextShout < ApplicationRecord
validates :body, presence: true, length: { in: 1..144 }
end
4 changes: 3 additions & 1 deletion app/views/dashboards/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
<iframe width="560" height="315" src="https://www.youtube.com/embed/Ye7FKc1JQe4" frameborder="0" allow="accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>

<%= form_for @shout do |form| %>
<%= form.text_field :body, placeholder: "Shout here!", required: true %>
<%= form.fields_for :content do |content_form| %>
<%= content_form.text_field :body, placeholder: "Shout here!", required: true %>
<% end %>
<%= form.submit "Shout!" %>
<% end %>

Expand Down
2 changes: 1 addition & 1 deletion app/views/shouts/_shout.html.erb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div>
<%= link_to shout.username, shout.user %>
<%= shout.id %>
<%= shout.body %>
<%= shout.content.body %>
<%= link_to shout do %>
<%= time_ago_in_words shout.created_at %> ago
<% end %>
Expand Down
9 changes: 9 additions & 0 deletions db/migrate/20190306021958_create_text_shouts.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
class CreateTextShouts < ActiveRecord::Migration[5.2]
def change
create_table :text_shouts do |t|
t.string :body, null: false

t.timestamps
end
end
end
36 changes: 36 additions & 0 deletions db/migrate/20190306022123_make_shouts_polymorphic.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
class MakeShoutsPolymorphic < ActiveRecord::Migration[5.2]
# Declare the involved models here so we don't have any validation
# problems in the future.
class Shout < ApplicationRecord
belongs_to :content, polymorphic: true
end
class TextShout < ApplicationRecord; end

def change
change_table(:shouts) do |t|
t.string :content_type
t.integer :content_id
t.index [:content_type, :content_id]
end


# With this we can reverse this migration, depending on direction
reversible do |direction|
Shout.reset_column_information
Shout.find_each do |shout|
# Copy the old Shouts to TextShouts.
direction.up do
text_shout = TextShout.create(body: shout.body)
shout.update(content_id: text_shout.id, content_type: "TextShout")
end

direction.down do
shout.update(body: shout.content.body)
shout.content.destroy
end
end
end

remove_column :shouts, :body, :string
end
end
12 changes: 10 additions & 2 deletions db/schema.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,27 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 2019_03_05_161052) do
ActiveRecord::Schema.define(version: 2019_03_06_022123) do

# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"

create_table "shouts", force: :cascade do |t|
t.string "body", null: false
t.bigint "user_id"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.string "content_type"
t.integer "content_id"
t.index ["content_type", "content_id"], name: "index_shouts_on_content_type_and_content_id"
t.index ["user_id"], name: "index_shouts_on_user_id"
end

create_table "text_shouts", force: :cascade do |t|
t.string "body", null: false
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
end

create_table "users", force: :cascade do |t|
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
Expand Down