Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Connection.add_message_callback from python, there's a potential for deadlocks:
To prevent this we could make sure libmav does not hold locks when calling back to python, unlock GIL when calling Connection.expect (and others), or ensure the receive thread does not call back into python. This patch implements the last solution by introducing an (async) message queue. It allows python code to receive and handle messages at well-defined points.