Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating generator to fix PHP74 related bug #395

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

funkjedi
Copy link
Contributor

@funkjedi funkjedi commented Aug 1, 2020

With PHP74 deprecation warnings are thrown when using any of the generated classes which don't have parents.

Deprecated: Cannot use "parent" when current class scope has no parent

This updates the generator to check if the class is a subclass when appending the jsonSerialize method.


#382 #383

@viable-hartman
Copy link

Greetings! I see this has been approved already, and I've tested this fix successfully locally.

Any idea when this will go out in a release for composer installs as I'd really love to start running PHP 7.4 in my production environment. This is the only library holding me up ATM.

Great work and Thanks!

@ghost
Copy link

ghost commented Oct 1, 2020

I'm in the same boat. It would be a great help to see this in a release soon.

Thanks so much!

@saqijaan
Copy link

@TCURT15 could you please merge this pull request. we have issues with php 7.4 version and waiting for this fix to be released.

@hui591463265
Copy link

waiting for this fix, please merge it in

@taufpate
Copy link

@TCURT15 please! could you please merge this pull request? it's important!

@TCURT15
Copy link

TCURT15 commented Jan 18, 2021

I do not have the permission nor ability to merge the pull request. I accidentally approved the changes when looking at them. I am in the same boat as everyone else.

@gnongsie gnongsie changed the base branch from future to php-version-upgrade February 10, 2021 09:06
@gnongsie gnongsie merged commit c584eed into AuthorizeNet:php-version-upgrade Feb 10, 2021
@mav2287 mav2287 mentioned this pull request Feb 22, 2021
@mav2287
Copy link

mav2287 commented Feb 22, 2021

@funkjedi are you planning on doing a similar fix for PHP 8.0? It looks like this fixes it on 7.4, but for some reason the parent error comes back in php 8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

8 participants