QE: Share image #572
QE: Share image #572
Conversation
pinarol
added
enhance
|
 |
App Name |  Gravatar Prototype Build |
| Build Number | 1772 | |
| Version | 1.0 | |
| Bundle ID | com.automattic.gravatar-sdk-demo-uikit.prototype-build | |
| Commit | 8821ead | |
| App Center Build | Gravatar SDK Demo - UIKit #411 |
# Conflicts: # Demo/Gravatar-Demo.xcodeproj/project.pbxproj
| @@ -30,8 +31,7 @@ class AvatarPickerViewModel: ObservableObject { | |||
| @Published var selectedAvatarURL: URL? | |||
| @Published private(set) var backendSelectedAvatarURL: URL? | |||
| @Published private(set) var gridResponseStatus: Result<Void, Error>? | |||
|
|
|||
| let grid: AvatarGridModel = .init(avatars: []) | |||
| @Published private(set) var grid: AvatarGridModel = .init(avatars: []) | |||
There was a problem hiding this comment.
This should have been a @Published var from the beginning imo. Otherwise the UI can fail to get updated properly.
|
⛏️ small adjustment We will want to append an ellipsis to the "Share" menu item:
|
Done. |
|
I test in the real device as well. Maybe the tapping area wasn't big enough for you and we need to make it a bit bigger 🤔 |
|
The problem seems to be related with iOS 17.x. Putting the Menu in the overlay doesn't seem to work there. I made a fix. Feel free to check again. @andrewdmontgomery and good catch 🎉 |
Closes #566
Description
Opens a share sheet via the avatar menu. Downloads the image in full size before that. Otherwise the share sheet doesn't share the image. Also adding the URL because then the metadata is captured by the system and automatically displayed in the share sheet's navigation bar.
Discussion
I wonder how you feel about the medium detent for the share sheet. I added it to be able to test it, but not sure how I feel about it. Please also test the full size sheet by just commenting out
.presentationDetentsIfAvailable([.medium, .large])and compare.Testing Steps
Test with both horizontal and vertical layouts.
Try different color schemes.
Test an error case like for example turn off internet.
Demo app > Quick Editor > Avatar ... menu > Share