Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/php83 compatibility #1571

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ti3Et0s
Copy link

@Ti3Et0s Ti3Et0s commented Oct 25, 2024

Changes proposed in this Pull Request:

  • Add local PHPCS configuration to handle PHP 8.3 deprecation notices
  • Create temporary workaround until WPCS is updated for PHP 8.3 support
  • Exclude problematic WordPress-specific sniffs while maintaining basic code quality checks

Related issue:

Testing:

  1. Run composer lint:wpcs with PHP 8.3
  2. Verify that linting passes without deprecation notices
  3. Verify that basic code quality checks are still enforced

Notes:

This is a temporary solution to address PHP 8.3 deprecation notices in WPCS. The approach:

  • Adds phpcs.local.xml with modified rules to avoid PHP 8.3 deprecation notices
  • Maintains basic code quality checks while excluding problematic sniffs
  • Will be reverted once WPCS adds proper PHP 8.3 support

This fix allows development to continue with PHP 8.3 while waiting for upstream fixes in WPCS.

…bility

- Create local PHPCS configuration to bypass PHP 8.3 deprecation notices
- Exclude WordPress-specific rules that cause issues with PHP 8.3
- Maintain basic code quality checks while allowing WordPress conventions
- This is a temporary solution until WPCS is updated for PHP 8.3 support
@jrfnl
Copy link
Contributor

jrfnl commented Oct 25, 2024

This PR should be rejected. WPCS should be updated to use a 3.x version instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants