Footer credit: Remove customizer option for block themes (take 2) (#3…

…8559)

Reintroduces the removal of the "Footer Credit" option from the Customizer for block themes (#38473) which was reverted in #38557 since it caused fatal errors on sites with child themes.

To prevent the fatal errors, we know wait for the `init` action before checking `wp_is_block_theme`.

Props to @Automattic/lego for finding the culprit.

projects/plugins/wpcomsh/changelog/remove-wpcomsh-customizer-footer-credit-block-themes-2

@@ -0,0 +1,4 @@
+Significance: patch
+Type: removed
+
+Footer credit: Remove customizer option for block themes

projects/plugins/wpcomsh/footer-credit/footer-credit/customizer.php

@@ -134,5 +134,13 @@ function footercredits_sanitize_setting( $val ) {
 	}
 }
 
-// Setup the Theme Customizer settings and controls...
-add_action( 'customize_register', 'footercredits_register', 99 );
+/**
+ * Setup the Footer Credit customizer settings and controls for classic themes only.
+ * We don't support the footer credit on block themes, see https://wp.me/paYJgx-51l.
+ */
+function footercredits_init() {
+	if ( ! wp_is_block_theme() ) {
+		add_action( 'customize_register', 'footercredits_register', 99 );
+	}
+}
+add_action( 'init', 'footercredits_init' );