Skip to content

Commit

Permalink
[Boost] Fix styles around CSS and JS concatenate options (#35150)
Browse files Browse the repository at this point in the history
* Fix JS and CSS minify styles

* Cleanup

* changelog

* version bump boost, as required by monorepo tooling

---------

Co-authored-by: Mark George <[email protected]>
  • Loading branch information
thingalon and Mark George authored Jan 22, 2024
1 parent b8e9e8b commit 0b37082
Show file tree
Hide file tree
Showing 8 changed files with 26 additions and 9 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
@import "../../../css/main/variables.scss";

.minify-meta {
align-items: flex-start;
display: flex;
flex-direction: row;
font-size: 14px;
line-height: 22px;
}

.summary {
flex-grow: 1;
}

.manage-excludes {
display: flex;
flex-direction: column;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const MetaComponent = ( { inputLabel, buttonText, placeholder, datasyncKey }: Pr
const htmlId = `jb-minify-meta-${ datasyncKey }`;

return (
<div className="jb-critical-css__meta">
<div className={ styles[ 'minify-meta' ] }>
{ isEditing ? (
<div className={ styles[ 'manage-excludes' ] }>
<label htmlFor={ htmlId }>{ inputLabel }</label>
Expand All @@ -43,7 +43,7 @@ const MetaComponent = ( { inputLabel, buttonText, placeholder, datasyncKey }: Pr
</div>
) : (
<>
<div className="summary">
<div className={ styles.summary }>
{ values.length > 0 && (
<div className="successes">
{ sprintf(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ export const useMetaQuery = ( key: MinifyMetaKeys ) => {
mutate( text.split( ',' ).map( item => item.trim() ) );
}

return [ data, updateValues ] as const;
return [ data || [], updateValues ] as const;
};
5 changes: 5 additions & 0 deletions projects/plugins/boost/changelog/fix-minify-styles
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Significance: patch
Type: fixed
Comment: Fixed broken styling around css and js minify


4 changes: 2 additions & 2 deletions projects/plugins/boost/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Boost your WordPress site's performance, from the creators of Jetpack",
"type": "library",
"license": "GPL-2.0-or-later",
"version": "3.0.0-beta",
"version": "3.0.1-alpha",
"authors": [
{
"name": "Automattic, Inc.",
Expand Down Expand Up @@ -73,7 +73,7 @@
"platform": {
"ext-intl": "0.0.0"
},
"autoloader-suffix": "b1e77e6231d50e7663f84529b6a3dfda_jetpack_boostⓥ3_0_0_beta",
"autoloader-suffix": "b1e77e6231d50e7663f84529b6a3dfda_jetpack_boostⓥ3_0_1_alpha",
"allow-plugins": {
"roots/wordpress-core-installer": true,
"automattic/jetpack-autoloader": true,
Expand Down
2 changes: 1 addition & 1 deletion projects/plugins/boost/composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions projects/plugins/boost/jetpack-boost.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* Plugin Name: Jetpack Boost
* Plugin URI: https://jetpack.com/boost
* Description: Boost your WordPress site's performance, from the creators of Jetpack
* Version: 3.0.0-beta
* Version: 3.0.1-alpha
* Author: Automattic - Jetpack Site Speed team
* Author URI: https://jetpack.com/boost/
* License: GPL-2.0+
Expand All @@ -29,7 +29,7 @@
die;
}

define( 'JETPACK_BOOST_VERSION', '3.0.0-beta' );
define( 'JETPACK_BOOST_VERSION', '3.0.1-alpha' );
define( 'JETPACK_BOOST_SLUG', 'jetpack-boost' );

if ( ! defined( 'JETPACK_BOOST_CLIENT_NAME' ) ) {
Expand Down
2 changes: 1 addition & 1 deletion projects/plugins/boost/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "jetpack-boost",
"version": "3.0.0-beta",
"version": "3.0.1-alpha",
"description": "Boost your WordPress site's performance, from the creators of Jetpack",
"directories": {
"test": "tests"
Expand Down

0 comments on commit 0b37082

Please sign in to comment.