Admin menu: Fix "Appearance > Themes" menu for WP.com classic sites (#…

…36934)
Automattic · Apr 17, 2024 · 2874c2e · 2874c2e
1 parent f56c7a4
commit 2874c2e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/projects/packages/jetpack-mu-wpcom/changelog/fix-theme-showcase-menu b/projects/packages/jetpack-mu-wpcom/changelog/fix-theme-showcase-menu
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fixed
+
+Fixed a WP.com only issue that forced the Themes menu to always point to Calypso even when the classic interface was set
diff --git a/projects/packages/jetpack-mu-wpcom/src/features/wpcom-themes/wpcom-themes.php b/projects/packages/jetpack-mu-wpcom/src/features/wpcom-themes/wpcom-themes.php
@@ -60,11 +60,6 @@ function wpcom_themes_add_theme_showcase_menu() {
 		return;
 	}
 
-	// Bail on Simple sites, since "Appearance > Themes" already links to the Theme Showcase on those.
-	if ( defined( 'IS_WPCOM' ) && IS_WPCOM ) {
-		return;
-	}
-
 	$site_slug = wp_parse_url( home_url(), PHP_URL_HOST );
 	add_submenu_page( 'themes.php', esc_attr__( 'Theme Showcase', 'jetpack-mu-wpcom' ), __( 'Theme Showcase', 'jetpack-mu-wpcom' ), 'read', "https://wordpress.com/themes/$site_slug?ref=wpcom-themes-menu" );
 }

diff --git a/projects/plugins/jetpack/changelog/fix-theme-showcase-menu b/projects/plugins/jetpack/changelog/fix-theme-showcase-menu
@@ -0,0 +1,5 @@
+Significance: patch
+Type: other
+Comment: Fixed a WP.com only issue that forced the Themes menu to always point to Calypso even when the classic interface was set
+
+
diff --git a/projects/plugins/jetpack/modules/masterbar/admin-menu/class-admin-menu.php b/projects/plugins/jetpack/modules/masterbar/admin-menu/class-admin-menu.php
@@ -290,7 +290,7 @@ public function add_appearance_menu() {
 			$default_customize_background_slug_2 => add_query_arg( array( 'autofocus' => array( 'section' => 'colors_manager_tool' ) ), $customize_url ),
 		);
 
-		if ( self::DEFAULT_VIEW === $this->get_preferred_view( 'themes.php' ) || self::CLASSIC_VIEW === $this->get_preferred_view( 'themes.php' ) ) {
+		if ( self::DEFAULT_VIEW === $this->get_preferred_view( 'themes.php' ) ) {
 			$submenus_to_update['themes.php'] = 'https://wordpress.com/themes/' . $this->domain;
 		}