Fix PHAN errors

Automattic · Dec 17, 2024 · 33c7e05 · 33c7e05
1 parent aba4411
commit 33c7e05
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/projects/packages/my-jetpack/src/products/class-newsletter.php b/projects/packages/my-jetpack/src/products/class-newsletter.php
@@ -54,7 +54,7 @@ class Newsletter extends Module_Product {
 	/**
 	 * Whether this product requires a user connection
 	 *
-	 * @var string
+	 * @var boolean
 	 */
 	public static $requires_user_connection = true;
 
@@ -170,6 +170,10 @@ public static function get_manage_url() {
 	 * @return null|WP_Error Null on success, WP_Error on invalid file.
 	 */
 	public static function activate_plugin() {
-		return activate_plugin( static::get_installed_plugin_filename( self::JETPACK_PLUGIN_SLUG ) );
+		$plugin_filename = static::get_installed_plugin_filename( self::JETPACK_PLUGIN_SLUG );
+
+		if ( $plugin_filename ) {
+			return activate_plugin( $plugin_filename );
+		}
 	}
 }
diff --git a/projects/packages/my-jetpack/src/products/class-related-posts.php b/projects/packages/my-jetpack/src/products/class-related-posts.php
@@ -54,7 +54,7 @@ class Related_Posts extends Module_Product {
 	/**
 	 * Whether this product requires a user connection
 	 *
-	 * @var string
+	 * @var boolean
 	 */
 	public static $requires_user_connection = false;
 
@@ -170,6 +170,10 @@ public static function get_manage_url() {
 	 * @return null|WP_Error Null on success, WP_Error on invalid file.
 	 */
 	public static function activate_plugin() {
-		return activate_plugin( static::get_installed_plugin_filename( self::JETPACK_PLUGIN_SLUG ) );
+		$plugin_filename = static::get_installed_plugin_filename( self::JETPACK_PLUGIN_SLUG );
+
+		if ( $plugin_filename ) {
+			return activate_plugin( $plugin_filename );
+		}
 	}
 }
diff --git a/projects/packages/my-jetpack/src/products/class-site-accelerator.php b/projects/packages/my-jetpack/src/products/class-site-accelerator.php
@@ -54,7 +54,7 @@ class Site_Accelerator extends Module_Product {
 	/**
 	 * Whether this product requires a user connection
 	 *
-	 * @var string
+	 * @var boolean
 	 */
 	public static $requires_user_connection = false;
 
@@ -170,6 +170,10 @@ public static function get_manage_url() {
 	 * @return null|WP_Error Null on success, WP_Error on invalid file.
 	 */
 	public static function activate_plugin() {
-		return activate_plugin( static::get_installed_plugin_filename( self::JETPACK_PLUGIN_SLUG ) );
+		$plugin_filename = static::get_installed_plugin_filename( self::JETPACK_PLUGIN_SLUG );
+
+		if ( $plugin_filename ) {
+			return activate_plugin( $plugin_filename );
+		}
 	}
 }