Woo Analytics: prevent accessing undefined wp.hooks on checkout (#36560)

* Add checks for wp.hooks before accessing on checkout * Add changelog * bump version --------- Co-authored-by: Jeremy Herve <[email protected]>
Automattic · Apr 3, 2024 · 41890da · 41890da
1 parent b0bbec5
commit 41890da
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 8 deletions.
diff --git a/projects/packages/woocommerce-analytics/changelog/fix-wp-hooks-check b/projects/packages/woocommerce-analytics/changelog/fix-wp-hooks-check
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fixed
+
+Fixed a JavaScript error when accessing the Shortcode checkout with WooCommerce Analytics enabled
diff --git a/projects/packages/woocommerce-analytics/src/class-universal.php b/projects/packages/woocommerce-analytics/src/class-universal.php
@@ -244,14 +244,16 @@ function ( $payment_gateway ) {
 						if ( true === cartItem_{$cart_item_key}_logged ) {
 							return;
 						}
-						wp.hooks.addAction( 'wcpay.payment-request.availability', 'wcpay', function ( args ) {
-							properties.express_checkout = args.paymentRequestType;
-						} );
-							properties.checkout_page_contains_checkout_block = '0';
-							properties.checkout_page_contains_checkout_shortcode = '1';
+						if ( typeof wp !== 'undefined' && typeof wp.hooks !== 'undefined' && typeof wp.hooks.addAction === 'function' ) {
+							wp.hooks.addAction( 'wcpay.payment-request.availability', 'wcpay', function ( args ) {
+								properties.express_checkout = args.paymentRequestType;
+							} );
+						}
+						properties.checkout_page_contains_checkout_block = '0';
+						properties.checkout_page_contains_checkout_shortcode = '1';
 
-							_wca.push( properties );
-							cartItem_{$cart_item_key}_logged = true;
+						_wca.push( properties );
+						cartItem_{$cart_item_key}_logged = true;
 
 					} );
 				}

diff --git a/projects/packages/woocommerce-analytics/src/class-woocommerce-analytics.php b/projects/packages/woocommerce-analytics/src/class-woocommerce-analytics.php
@@ -20,7 +20,7 @@ class Woocommerce_Analytics {
 	/**
 	 * Package version.
 	 */
-	const PACKAGE_VERSION = '0.1.2';
+	const PACKAGE_VERSION = '0.1.3-alpha';
 
 	/**
 	 * Initializer.