AI Assistant: Fix block inserter behavior when Breve is enabled (#38483)

* move md5 check out of tree preparation * changelog
Automattic · Jul 23, 2024 · 4c6c1d6 · 4c6c1d6
1 parent 89b9dac
commit 4c6c1d6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/projects/plugins/jetpack/changelog/fix-jetpack-ai-breve-block-inserter b/projects/plugins/jetpack/changelog/fix-jetpack-ai-breve-block-inserter
@@ -0,0 +1,4 @@
+Significance: patch
+Type: other
+
+AI Assistant: Fix block inserter behavior when Breve is enabled
diff --git a/...ugins/jetpack/extensions/plugins/ai-assistant-plugin/components/breve/highlight/index.tsx b/...ugins/jetpack/extensions/plugins/ai-assistant-plugin/components/breve/highlight/index.tsx
@@ -248,28 +248,31 @@ export function registerBreveHighlights() {
 			interactive: false,
 			edit: () => {},
 			...configSettings,
-			__experimentalGetPropsForEditableTreePreparation( _select, { blockClientId } ) {
+			__experimentalGetPropsForEditableTreePreparation() {
 				return {
 					isProofreadEnabled: (
 						globalSelect( 'jetpack/ai-breve' ) as BreveSelect
 					 ).isProofreadEnabled(),
-					currentMd5: ( globalSelect( 'jetpack/ai-breve' ) as BreveSelect ).getBlockMd5(
-						formatName,
-						blockClientId
-					),
 					isFeatureEnabled: ( globalSelect( 'jetpack/ai-breve' ) as BreveSelect ).isFeatureEnabled(
 						config.name
 					),
 				};
 			},
 			__experimentalCreatePrepareEditableTree(
-				{ isProofreadEnabled, isFeatureEnabled, currentMd5 },
+				{ isProofreadEnabled, isFeatureEnabled },
 				{ blockClientId, richTextIdentifier }
 			) {
 				return ( formats: Array< RichTextFormatList >, text: string ) => {
 					const record = { formats, text } as RichTextValue;
 					const type = formatName;
 
+					// Has to be defined here, as adding it to __experimentalGetPropsForEditableTreePreparation
+					// causes an issue with the block inserter. ref p1721746774569699-slack-C054LN8RNVA
+					const currentMd5 = ( globalSelect( 'jetpack/ai-breve' ) as BreveSelect ).getBlockMd5(
+						formatName,
+						blockClientId
+					);
+
 					if ( text && isProofreadEnabled && isFeatureEnabled ) {
 						const block = globalSelect( 'core/block-editor' ).getBlock( blockClientId );
 						const blockContent = getBlockContent( block );