-
Notifications
You must be signed in to change notification settings - Fork 800
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add/mj card update after async site connection (#38549)
* Add My Jetpack card refetch after async site connection * Fix fetch product query to include product ID to avoid conflicts * changelog * Improve typing of connected product card * changelog * Fix project versions * Remove testing change
- Loading branch information
1 parent
95f790f
commit 4cfd334
Showing
7 changed files
with
69 additions
and
19 deletions.
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
projects/js-packages/components/changelog/export-button-props-type
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: patch | ||
Type: added | ||
|
||
Export button props type to be used elsewhere |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
projects/packages/my-jetpack/_inc/components/product-card/types.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import type { ButtonProps } from '@automattic/jetpack-components'; | ||
import type { ReactNode } from 'react'; | ||
|
||
type ProductButtonProps = Pick< | ||
ButtonProps, | ||
'size' | 'variant' | 'weight' | 'disabled' | 'className' | ||
>; | ||
|
||
export type AdditionalAction = ProductButtonProps & { | ||
href: string; | ||
label: string; | ||
onClick: () => void; | ||
}; | ||
|
||
export type SecondaryAction = ProductButtonProps & { | ||
href: string; | ||
label: string; | ||
shouldShowButton?: () => boolean; | ||
onClick: () => void; | ||
positionFirst?: boolean; | ||
isExternalLink?: boolean; | ||
icon?: ReactNode; | ||
iconSize?: number; | ||
disabled?: boolean; | ||
isLoading?: boolean; | ||
className?: string; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
projects/packages/my-jetpack/changelog/add-mj-card-update-after-async-site-connection
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: patch | ||
Type: added | ||
|
||
Async card update after async site connection |