Boost: Fix sending multiple tracks when speed score changes (#40700)

* Fix sending multiple tracks when speed score changes * Fix sending speed score changed tracks when popup was dismissed * add changelog --------- Co-authored-by: Adnan Haque <[email protected]>
Automattic · Dec 20, 2024 · 8109ade · 8109ade
1 parent e564fe0
commit 8109ade
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/projects/plugins/boost/app/assets/src/js/features/speed-score/pop-out/pop-out.tsx b/projects/plugins/boost/app/assets/src/js/features/speed-score/pop-out/pop-out.tsx
@@ -2,7 +2,7 @@ import { animated, useSpring } from '@react-spring/web';
 import CloseButton from '$features/ui/close-button/close-button';
 import styles from './pop-out.module.scss';
 import { __ } from '@wordpress/i18n';
-import { ReactNode, useState } from 'react';
+import { ReactNode, useState, useEffect } from 'react';
 import { Button } from '@wordpress/components';
 import { useDismissibleAlertState } from '$features/performance-history/lib/hooks';
 import { getRedirectUrl } from '@automattic/jetpack-components';
@@ -77,11 +77,13 @@ function PopOut( { scoreChange }: Props ) {
 
 	const hideAlert = () => setClose( true );
 
-	if ( hasScoreChanged ) {
-		recordBoostEvent( 'speed_score_alert_shown', {
-			score_direction: scoreChange > 0 ? 'up' : 'down',
-		} );
-	}
+	useEffect( () => {
+		if ( hasScoreChanged && ! isDismissed && ! isClosed ) {
+			recordBoostEvent( 'speed_score_alert_shown', {
+				score_direction: scoreChange > 0 ? 'up' : 'down',
+			} );
+		}
+	}, [ hasScoreChanged, scoreChange, isDismissed, isClosed ] );
 
 	const animationStyles = useSpring( {
 		from: {

diff --git a/projects/plugins/boost/changelog/fix-speed-score-changed-tracks b/projects/plugins/boost/changelog/fix-speed-score-changed-tracks
@@ -0,0 +1,5 @@
+Significance: patch
+Type: fixed
+Comment: Fix for an unreleased change.
+
+