Extract the share logic to base class

Automattic · Dec 11, 2024 · 8a796c6 · 8a796c6
1 parent 836683d
commit 8a796c6
Show file tree

Hide file tree

Showing 2 changed files with 95 additions and 78 deletions.
diff --git a/projects/packages/publicize/src/rest-endpoints/class-base-controller.php b/projects/packages/publicize/src/rest-endpoints/class-base-controller.php
@@ -0,0 +1,90 @@
+<?php
+/**
+ * Base Controller class.
+ *
+ * @package automattic/jetpack-publicize
+ */
+
+namespace Automattic\Jetpack\Publicize\Rest_Endpoints;
+
+use Automattic\Jetpack\Status\Host;
+use WP_Error;
+use WP_REST_Controller;
+use WP_REST_Request;
+use WP_REST_Response;
+
+/**
+ * Base controller for Publicize endpoints.
+ */
+abstract class Base_Controller extends WP_REST_Controller {
+
+	/**
+	 * Constructor.
+	 */
+	public function __construct() {
+		$this->namespace = 'wpcom/v3';
+
+		$this->wpcom_is_wpcom_only_endpoint = true;
+	}
+
+	/**
+	 * Check if we are on WPCOM.
+	 *
+	 * @return bool
+	 */
+	public static function is_wpcom() {
+		return ( new Host() )->is_wpcom_simple();
+	}
+
+	/**
+	 * Filters out data based on ?_fields= request parameter
+	 *
+	 * @param array           $item    Item to prepare.
+	 * @param WP_REST_Request $request Full details about the request.
+	 *
+	 * @return WP_REST_Response filtered item
+	 */
+	public function prepare_item_for_response( $item, $request ) {
+		if ( ! is_callable( array( $this, 'get_fields_for_response' ) ) ) {
+			return rest_ensure_response( $item );
+		}
+
+		$fields = $this->get_fields_for_response( $request );
+
+		$response_data = array();
+		foreach ( $item as $field => $value ) {
+			if ( in_array( $field, $fields, true ) ) {
+				$response_data[ $field ] = $value;
+			}
+		}
+
+		return rest_ensure_response( $response_data );
+	}
+
+	/**
+	 * Verify that user can access Publicize data
+	 *
+	 * @return true|WP_Error
+	 */
+	public function get_items_permission_check() {
+		global $publicize;
+
+		if ( ! $publicize ) {
+			return new WP_Error(
+				'publicize_not_available',
+				__( 'Sorry, Jetpack Social is not available on your site right now.', 'jetpack-publicize-pkg' ),
+				array( 'status' => rest_authorization_required_code() )
+			);
+		}
+
+		if ( $publicize->current_user_can_access_publicize_data() ) {
+			return true;
+		}
+
+		return new WP_Error(
+			'invalid_user_permission_publicize',
+			__( 'Sorry, you are not allowed to access Jetpack Social data on this site.', 'jetpack-publicize-pkg' ),
+			array( 'status' => rest_authorization_required_code() )
+		);
+	}
+}
diff --git a/projects/packages/publicize/src/rest-endpoints/class-connections-controller.php b/projects/packages/publicize/src/rest-endpoints/class-connections-controller.php
@@ -10,45 +10,24 @@
 use Automattic\Jetpack\Connection\Client;
 use Automattic\Jetpack\Connection\Manager;
 use Automattic\Jetpack\Publicize\Connection_Fields;
-use WP_Error;
-use WP_REST_Controller;
 use WP_REST_Request;
 use WP_REST_Response;
 use WP_REST_Server;
 
 /**
- * Registers the REST routes
+ * Connections Controller class.
  */
-class Connections_Controller extends WP_REST_Controller {
-
-	/**
-	 * Whether we are on WPCOM.
-	 *
-	 * @var bool $is_wpcom
-	 */
-	protected $is_wpcom = false;
+class Connections_Controller extends Base_Controller {
 
 	/**
 	 * Constructor.
 	 */
 	public function __construct() {
-		$this->namespace = 'wpcom/v3';
+		parent::__construct();
+
 		$this->rest_base = 'publicize/connections';
 
 		add_action( 'rest_api_init', array( $this, 'register_routes' ) );
-
-		$this->is_wpcom = defined( 'IS_WPCOM' ) && IS_WPCOM;
-
-		$this->wpcom_is_wpcom_only_endpoint = true;
-	}
-
-	/**
-	 * Check if we are on WPCOM.
-	 *
-	 * @return bool
-	 */
-	protected static function is_wpcom() {
-		return defined( 'IS_WPCOM' ) && IS_WPCOM;
 	}
 
 	/**
@@ -268,60 +247,8 @@ protected static function get_connections_test_status() {
 
 		return $test_results_map;
 	}
-
-	/**
-	 * Filters out data based on ?_fields= request parameter
-	 *
-	 * @param array           $item    Item to prepare.
-	 * @param WP_REST_Request $request Full details about the request.
-	 *
-	 * @return WP_REST_Response filtered item
-	 */
-	public function prepare_item_for_response( $item, $request ) {
-		if ( ! is_callable( array( $this, 'get_fields_for_response' ) ) ) {
-			return rest_ensure_response( $item );
-		}
-
-		$fields = $this->get_fields_for_response( $request );
-
-		$response_data = array();
-		foreach ( $item as $field => $value ) {
-			if ( in_array( $field, $fields, true ) ) {
-				$response_data[ $field ] = $value;
-			}
-		}
-
-		return rest_ensure_response( $response_data );
-	}
-
-	/**
-	 * Verify that user can access Publicize data
-	 *
-	 * @return true|WP_Error
-	 */
-	public function get_items_permission_check() {
-		global $publicize;
-
-		if ( ! $publicize ) {
-			return new WP_Error(
-				'publicize_not_available',
-				__( 'Sorry, Jetpack Social is not available on your site right now.', 'jetpack-publicize-pkg' ),
-				array( 'status' => rest_authorization_required_code() )
-			);
-		}
-
-		if ( $publicize->current_user_can_access_publicize_data() ) {
-			return true;
-		}
-
-		return new WP_Error(
-			'invalid_user_permission_publicize',
-			__( 'Sorry, you are not allowed to access Jetpack Social data on this site.', 'jetpack-publicize-pkg' ),
-			array( 'status' => rest_authorization_required_code() )
-		);
-	}
 }
 
-if ( defined( 'IS_WPCOM' ) && IS_WPCOM ) {
+if ( Base_Controller::is_wpcom() ) {
 	wpcom_rest_api_v2_load_plugin( Connections_Controller::class );
 }