Adjust copy on Connection banner (#35401)

* Update copy to clarify that user connection is required * changelog * Fix notice status * Update changelog * Fix logic to display message for one product
Automattic · Feb 2, 2024 · 8bf3d3c · 8bf3d3c
1 parent a9cd697
commit 8bf3d3c
Show file tree

Hide file tree

Showing 11 changed files with 55 additions and 25 deletions.
diff --git a/projects/packages/my-jetpack/_inc/hooks/use-connection-watcher/index.js b/projects/packages/my-jetpack/_inc/hooks/use-connection-watcher/index.js
@@ -31,35 +31,17 @@ export default function useConnectionWatcher() {
 	);
 
 	const needsUserConnectionMessage =
-		productsThatRequiresUserConnection.length > 1
-			? __(
+		productsThatRequiresUserConnection.length === 1
+			? oneProductMessage
+			: __(
 					'Some products need a user connection to WordPress.com to be able to work.',
 					'jetpack-my-jetpack'
-			  )
-			: oneProductMessage;
-	const needsSiteConnectionMessage = __(
-		'Some products need a connection to WordPress.com to be able to work.',
-		'jetpack-my-jetpack'
-	);
+			  );
 
 	useEffect( () => {
-		if ( ! isSiteConnected ) {
-			setGlobalNotice( needsSiteConnectionMessage, {
-				status: 'warning',
-				actions: [
-					{
-						label: __( 'Connect your site to fix this', 'jetpack-my-jetpack' ),
-						onClick: navToConnection,
-						variant: 'link',
-						noDefaultClasses: true,
-					},
-				],
-			} );
-			return;
-		}
-		if ( requiresUserConnection ) {
+		if ( ! isSiteConnected || requiresUserConnection ) {
 			setGlobalNotice( needsUserConnectionMessage, {
-				status: 'error',
+				status: 'warning',
 				actions: [
 					{
 						label: __( 'Connect your user account to fix this', 'jetpack-my-jetpack' ),
@@ -71,7 +53,6 @@ export default function useConnectionWatcher() {
 		}
 	}, [
 		isSiteConnected,
-		needsSiteConnectionMessage,
 		needsUserConnectionMessage,
 		requiresUserConnection,
 		navToConnection,

diff --git a/projects/packages/my-jetpack/changelog/fix-welcome-banner-cta-copy b/projects/packages/my-jetpack/changelog/fix-welcome-banner-cta-copy
@@ -0,0 +1,4 @@
+Significance: minor
+Type: changed
+
+Update CTA copy on the connection banner to make it clear which type of connection we are going to request
diff --git a/projects/plugins/backup/changelog/fix-welcome-banner-cta-copy b/projects/plugins/backup/changelog/fix-welcome-banner-cta-copy
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/boost/changelog/fix-welcome-banner-cta-copy b/projects/plugins/boost/changelog/fix-welcome-banner-cta-copy
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/jetpack/changelog/fix-welcome-banner-cta-copy b/projects/plugins/jetpack/changelog/fix-welcome-banner-cta-copy
@@ -0,0 +1,5 @@
+Significance: patch
+Type: other
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/migration/changelog/fix-welcome-banner-cta-copy b/projects/plugins/migration/changelog/fix-welcome-banner-cta-copy
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/protect/changelog/fix-welcome-banner-cta-copy b/projects/plugins/protect/changelog/fix-welcome-banner-cta-copy
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/search/changelog/fix-welcome-banner-cta-copy b/projects/plugins/search/changelog/fix-welcome-banner-cta-copy
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/social/changelog/fix-welcome-banner-cta-copy b/projects/plugins/social/changelog/fix-welcome-banner-cta-copy
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/starter-plugin/changelog/fix-welcome-banner-cta-copy b/projects/plugins/starter-plugin/changelog/fix-welcome-banner-cta-copy
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+
diff --git a/projects/plugins/videopress/changelog/fix-welcome-banner-cta-copy b/projects/plugins/videopress/changelog/fix-welcome-banner-cta-copy
@@ -0,0 +1,5 @@
+Significance: patch
+Type: changed
+Comment: Updated composer.lock.
+
+