Skip to content

Commit

Permalink
Change design task for Writing and Free flows (#39189)
Browse files Browse the repository at this point in the history
The Write and Free launchpad checklists used the `design_selected` task
in their launchpad definitions. This task is always marked as done, even
if a design isn't actually selected, which is perfectly possible for
both of these flows - even likely for the write flow, depending upon the
precise path.

Now they use the `design_completed` task, which explicitly checks
whether a design has been selected before being marked as completed.
  • Loading branch information
dsas authored and gogdzl committed Oct 25, 2024
1 parent 7e007ca commit 907edfc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Launchpad: Require a design is selected before marking the step as complete in both the Write and Free flows
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ function wpcom_launchpad_get_task_list_definitions() {
'task_ids' => array(
'plan_selected',
'setup_free',
'design_selected',
'design_completed',
'domain_upsell',
'first_post_published',
'design_edited',
Expand Down Expand Up @@ -120,7 +120,7 @@ function wpcom_launchpad_get_task_list_definitions() {
},
'task_ids' => array(
'setup_write',
'design_selected',
'design_completed',
'plan_selected',
'first_post_published',
'site_launched',
Expand Down

0 comments on commit 907edfc

Please sign in to comment.