ci: Test against PHP 8.4 (#40255)

It'll be released soon, let's try testing against it.

To make it work, we had to fix one test in changelogger (PHP 8.4 changed
an error message) and disable deprecation warnings for a call to Phan in
a phan-plugins test because microsoft/tolerant-php-parser has not had a
8.4-safe release yet.

.github/files/generate-ci-matrix.php

@@ -59,7 +59,7 @@
 $matrix = array();
 
 // Add PHP tests.
-foreach ( array( '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ) as $php ) {
+foreach ( array( '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ) as $php ) {
 	$matrix[] = array(
 		'name'    => "PHP tests: PHP $php WP latest",
 		'script'  => 'test-php',

.github/versions.sh

@@ -6,4 +6,4 @@ PNPM_VERSION=9.3.0
 
 # Other useful version numbers.
 MIN_PHP_VERSION=7.2
-MAX_PHP_VERSION=8.3
+MAX_PHP_VERSION=8.4

.github/workflows/linting.yml

@@ -171,7 +171,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-versions: [ '7.2', '7.4', '8.0', '8.1', '8.2', '8.3' ]
+        php-versions: [ '7.2', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
         experimental: [ false ]
 
     steps:

docs/monorepo.md

@@ -41,7 +41,7 @@ All GitHub Actions configuration for the monorepo, including CI, lives in `.gith
 
 ## Compatibility
 
-All projects should be compatible with PHP versions WordPress supports. That's currently PHP 7.2 to 8.3.
+All projects should be compatible with PHP versions WordPress supports. That's currently PHP 7.2 to 8.4.
 
 ## First Time
 
@@ -266,15 +266,15 @@ If a project contains PHP tests (typically PHPUnit), it must define `.scripts.te
 
 A MySQL database is available if needed; credentials may be found in `~/.my.cnf`. Note that the host must be specified as `127.0.0.1`, as when passed `localhost` PHP will try to connect via a Unix domain socket which is not available in the Actions environment.
 
-Tests are run with a variety of supported PHP versions from 7.2 to 8.3. If you have tests that only need to be run once, run them when `PHP_VERSION` matches that in `.github/versions.sh`.
+Tests are run with a variety of supported PHP versions from 7.2 to 8.4. If you have tests that only need to be run once, run them when `PHP_VERSION` matches that in `.github/versions.sh`.
 
 #### PHP tests for non-plugins
 
 For all project types other than WordPress plugins, the necessary version of PHPUnit and/or any other tools should be pulled in via Composer.
 
 We currently make use of the following packages in testing; it's encouraged to use these rather than introducing other tools that serve the same purpose.
 
-* [yoast/phpunit-polyfills](https://packagist.org/packages/yoast/phpunit-polyfills) supplies polyfills for compatibility with PHPUnit 8.5 to 9.6, to support PHP 7.2 to 8.3.
+* [yoast/phpunit-polyfills](https://packagist.org/packages/yoast/phpunit-polyfills) supplies polyfills for compatibility with PHPUnit 8.5 to 9.6, to support PHP 7.2 to 8.4.
   * Do not use `Yoast\PHPUnitPolyfills\TestCases\TestCase` or `Yoast\PHPUnitPolyfills\TestCases\XTestCase`. Just use the `@before`, `@after`, `@beforeClass`, and `@afterClass` annotations directly.
 * PHPUnit's built-in mocking is used for class mocks.
 * [brain/monkey](https://packagist.org/packages/brain/monkey) is used for mocking functions, and can also provide some functions for minimal WordPress compatibility.

projects/packages/changelogger/changelog/add-ci-php-8.4

@@ -0,0 +1,5 @@
+Significance: patch
+Type: fixed
+Comment: Update a test for PHP 8.4
+
+

projects/packages/changelogger/tests/php/tests/src/SquashCommandTest.php

@@ -222,7 +222,7 @@ public function provideExecute() {
 				array(),
 				array(),
 				SquashCommand::FATAL_EXIT,
-				array( '{^Regex match failed: Delimiter must not be alphanumeric(?: or backslash|, backslash, or NUL)$}' ),
+				array( '{^Regex match failed: Delimiter must not be alphanumeric(?: or backslash|, backslash, or NUL(?: byte)?)$}' ),
 			),
 			'Squash by regex, regex matches nothing'      => array(
 				array(

projects/packages/phan-plugins/changelog/add-ci-php-8.4

@@ -0,0 +1,5 @@
+Significance: patch
+Type: fixed
+Comment: Work around microsoft/tolerant-php-parser not being 8.4-safe yet in test
+
+

projects/packages/phan-plugins/tests/php/IntegrationTest.php

@@ -101,12 +101,22 @@ private function runPhan( $dir, $usePolyfill = false, $analyzeTwice = false ) {
 		$printer = new CapturingJSONPrinter();
 		Phan::setPrinter( $printer );
 
-		Phan::analyzeFileList(
-			$this->codeBase,
-			static function () use ( $cli ) {
-				return $cli->getFileList();
+		$old = error_reporting();
+		try {
+			if ( $usePolyfill ) {
+				// microsoft/tolerant-php-parser raises PHP 8.4 deprecation warnings.
+				// @todo If it gets updated at some point, hopefully this can be removed.
+				error_reporting( $old & ~E_DEPRECATED );
 			}
-		);
+			Phan::analyzeFileList(
+				$this->codeBase,
+				static function () use ( $cli ) {
+					return $cli->getFileList();
+				}
+			);
+		} finally {
+			error_reporting( $old );
+		}
 
 		$expectFile = $this->chooseFile( "$dir/expect.json", $usePolyfill, $analyzeTwice );
 		$expect     = json_decode( file_get_contents( $expectFile ), true );