Skip to content

Commit

Permalink
Remove ENT_COMPAT step
Browse files Browse the repository at this point in the history
  • Loading branch information
tbradsha committed Dec 19, 2024
1 parent 2f56f6b commit bc7ac12
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
11 changes: 0 additions & 11 deletions projects/packages/jetpack-mu-wpcom/bin/sync-newspack-blocks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -209,15 +209,4 @@ for block_json_file in "$TARGET"/blocks/*/block.json; do
jq --tab '. += {"textdomain": "jetpack-mu-wpcom"}' "$block_json_file" > "$TMPFILE"
mv "$TMPFILE" "$block_json_file"
done

echo

# Warn about the need to use ENT_COMPAT.
echo "Please ensure htmlentities and html_entity_decode use 'ENT_COMPAT'!"
ent_compat_needed=$(grep -rino 'html_entity_decode\|htmlentities' --include="$TARGET/*.php")
if [[ -n $ent_compat_needed ]]; then
echo 'Detected the below instances:'
echo "$ent_compat_needed"
fi
echo
echo Sync done.
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,11 @@ This will pull the code from the release into this repository and perform the fo

Once the script has completed:
1. Ensure the changes shown match the changes in the release.
2. Manually ensure we use ENT_COMPAT [in the proper places](https://github.com/Automattic/jetpack/pull/38873/commits/16f57e6f01b6eed98a19cd0299261ce5ac075b8e).
3. Commit.
2. Commit.

### Local development

Sometimes, probably, you will need to sync the NHA code straight in your local environment. It means you will get working on both projects at the same time. For this situation, you'd like to reference the code source through the `path` bin script argument.
Sometimes, probably, you will need to sync the code straight in your local environment. It means you will get working on both projects at the same time. For this situation, you'd like to reference the code source through the `path` bin script argument.

```
pnpm run sync:newspack-blocks --path=/Absolute/path/of/newspack-blocks/
Expand Down

0 comments on commit bc7ac12

Please sign in to comment.