Skip to content

Commit

Permalink
Repo gardening: update PR review flow explanation markdown indent (#3…
Browse files Browse the repository at this point in the history
…8920)

* Repo gardening: update PR review flow explanation markdown

* changelog
  • Loading branch information
mreishus authored Aug 16, 2024
1 parent d501ec7 commit df98f84
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 9 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Check PR description: update PR review workflow explanation to have correct markdown indent
Original file line number Diff line number Diff line change
Expand Up @@ -498,15 +498,15 @@ The e2e test report can be found [here](https://automattic.github.io/jetpack-e2e
1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
A. Team Review: add the "[Status] Needs Team Review" label
- For most changes, including minor cross-team impacts.
- Example: Updating a team-specific component or a small change to a shared library.
B. Crew Review: add the "[Status] Needs Review" label
- For significant changes to core functionality.
- Example: Major updates to a shared library or complex features.
C. Both: Start with Team, then request Crew
- For complex changes or when you need extra confidence.
- Example: Refactor affecting multiple systems.
- **A. Team Review:** add the "[Status] Needs Team Review" label
- For most changes, including minor cross-team impacts.
- Example: Updating a team-specific component or a small change to a shared library.
- **B. Crew Review:** add the "[Status] Needs Review" label
- For significant changes to core functionality.
- Example: Major updates to a shared library or complex features.
- **C. Both:** Start with Team, then request Crew
- For complex changes or when you need extra confidence.
- Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.
Still unsure? Reach out in #jetpack-developers for guidance!`;
Expand Down

0 comments on commit df98f84

Please sign in to comment.