move gridVisibility out of the barchart and into the shared types

Automattic · Dec 20, 2024 · e9487a4 · e9487a4
1 parent 72f85a0
commit e9487a4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/projects/js-packages/charts/src/components/bar-chart/bar-chart.tsx b/projects/js-packages/charts/src/components/bar-chart/bar-chart.tsx
@@ -13,9 +13,7 @@ import { BaseTooltip } from '../tooltip';
 import styles from './bar-chart.module.scss';
 import type { BaseChartProps, SeriesData } from '../shared/types';
 
-interface BarChartProps extends BaseChartProps< SeriesData[] > {
-	gridVisibility?: 'x' | 'y' | 'xy' | 'none';
-}
+interface BarChartProps extends BaseChartProps< SeriesData[] > {}
 
 type BarChartTooltipData = { value: number; xLabel: string; yLabel: string; seriesIndex: number };
 

diff --git a/projects/js-packages/charts/src/components/shared/types.d.ts b/projects/js-packages/charts/src/components/shared/types.d.ts
@@ -106,6 +106,10 @@ export type BaseChartProps< T = DataPoint | DataPointDate > = {
 	 * Legend orientation
 	 */
 	legendOrientation?: 'horizontal' | 'vertical';
+	/**
+	 * Grid visibility
+	 */
+	gridVisibility?: 'x' | 'y' | 'xy' | 'none';
 };
 
 export type GridVisibilityOptions = 'x' | 'y' | 'xy' | 'none';