Fix/php error in inspect plugin (#36813)

* Fix: PHP warning due to the missing namespace variable * changelog
Automattic · Apr 22, 2024 · e9f0d96 · e9f0d96
1 parent a81f306
commit e9f0d96
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/projects/plugins/inspect/.phan/baseline.php b/projects/plugins/inspect/.phan/baseline.php
@@ -32,7 +32,6 @@
         'packages/Async_Option/Async_Option.php' => ['PhanParamTooMany'],
         'packages/Async_Option/Endpoint.php' => ['PhanParamTooMany'],
         'packages/Async_Option/Registry.php' => ['PhanCommentParamWithoutRealParam'],
-        'packages/Async_Option/Storage/WP_Option.php' => ['PhanUndeclaredProperty'],
     ],
     // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed.
     // (directory_suppressions will currently be ignored by subsequent calls to --save-baseline, but may be preserved in future Phan releases)

diff --git a/projects/plugins/inspect/changelog/fix-php-error-in-inspect-plugin b/projects/plugins/inspect/changelog/fix-php-error-in-inspect-plugin
@@ -0,0 +1,5 @@
+Significance: patch
+Type: fixed
+Comment: This PR fixes a minor PHP warning
+
+
diff --git a/projects/plugins/inspect/packages/Async_Option/Storage/WP_Option.php b/projects/plugins/inspect/packages/Async_Option/Storage/WP_Option.php
@@ -3,6 +3,7 @@
 namespace Automattic\Jetpack\Packages\Async_Option\Storage;
 
 class WP_Option implements Storage {
+	private $namespace;
 
 	public function __construct( $namepsace ) {
 		$this->namespace = $namepsace;