Add comment explaining Protect status exception, per feedback.

Automattic · Dec 20, 2024 · fd97fdc · fd97fdc
1 parent feff403
commit fd97fdc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/projects/packages/my-jetpack/_inc/components/product-card/status.tsx b/projects/packages/my-jetpack/_inc/components/product-card/status.tsx
@@ -77,6 +77,11 @@ const getStatusClassName: StatusStateFunction = ( slug, status, isOwned ) => {
 			return isOwned ? styles.warning : styles.inactive;
 		case PRODUCT_STATUSES.EXPIRED:
 		case PRODUCT_STATUSES.NEEDS_ATTENTION__WARNING:
+			/**
+			 * For the Protect card, even when it has a NEEDS_ATTENTION__{WARNING | ERROR}
+			 * status (it means threats have been detected), we still want to show the card
+			 * status as 'Active'.
+			 */
 			if ( slug === 'protect' ) {
 				return styles.active;
 			}

diff --git a/projects/packages/my-jetpack/src/products/class-protect.php b/projects/packages/my-jetpack/src/products/class-protect.php
@@ -295,6 +295,7 @@ public static function does_module_need_attention() {
 		if ( is_wp_error( $protect_data ) ) {
 			return $protect_threat_status; // false
 		}
+		$critical_threat_count = false;
 		if ( ! empty( $protect_data->threats ) ) {
 			$critical_threat_count = array_reduce(
 				$protect_data->threats,