Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Form makes "Block Inserter" disappear in Firefox #39144

Closed
sergeymitr opened this issue Aug 29, 2024 · 4 comments · Fixed by #39216
Closed

Contact Form makes "Block Inserter" disappear in Firefox #39144

sergeymitr opened this issue Aug 29, 2024 · 4 comments · Fixed by #39216
Assignees
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@sergeymitr
Copy link
Contributor

sergeymitr commented Aug 29, 2024

Impacted plugin

Jetpack

Quick summary

When you search for the "Contact Form" block in the "Block Inserter" while editing a post, "Block Inserter" disappears.

Steps to reproduce

  1. Create new JN site
  2. Connect Jetpack
  3. Use Firefox to create new post.
  4. Try to use the "Block insterter" (the "+" icon) to add Contact Form block.
  5. The block inserter will disappear as soon as that block's icon shows up.

A clear and concise description of what you expected to happen.

Block Inserter stays open and allows for Contact Form to be added to the post.

What actually happened

Block Inserter disappears.

Impact

All

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

Typing /contact in the post content allows adding the Contact Form block without using the Block Inserter.

Platform (Simple and/or Atomic)

Self-hosted

Logs or notes

Browser: Only fresh versions of Firefox are affected (~128.0.3 and above).
Jetpack version: 13.6 and above.

Screen.Recording.2024-08-29.at.10.59.58.mov
@sergeymitr sergeymitr added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Aug 29, 2024
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal labels Aug 29, 2024
@jeherve jeherve added [Feature] Contact Form [Block] Contact Form Form block (also see Contact Form label) Triaged and removed Needs triage Ticket needs to be triaged labels Aug 30, 2024
@jeherve jeherve moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Aug 30, 2024
@jeherve jeherve changed the title Contact Form makes "Block Insterter" disappear in Firefox Contact Form makes "Block Inserter" disappear in Firefox Aug 30, 2024
@monsieur-z
Copy link
Contributor

@dhasilva, pinging you because the root of the issue seems to be this line of code in the ai-assistant extension.

To add to the description, I've been able to reproduce the issue either by typing something in the block inserter search input or hovering a Forms related block (Form, Contact Form, Name Field, etc.) with the mouse cursor. The exact trigger may vary depending on the browser version, but we've been able to replicate the issue with Firefox versions at least back to 127. We didn't notice any issues with the block inserter on Chrome, though.

The last Jetpack version in which the block inserter was stable in FF was 13.5, so the issue was introduced in 13.6. Locally, both with the plugins/[email protected] tag and trunk branch, commenting the line mentioned above fixes the issue. Do you have any takes on why that might be the case?

@dhasilva
Copy link
Contributor

dhasilva commented Sep 2, 2024

Do you have any takes on why that might be the case?

Not yet. IIRC the block inserter does not throw any error, so it will require some trial and error to identify exactly what the issue is with the block extension. I'll do that soon and post an update here when I find out what is happening.

@dhasilva
Copy link
Contributor

dhasilva commented Sep 2, 2024

I was able to reproduce it. My guess at this moment is that we are auto-focusing on the AI input, and when that happens inside the preview block it causes this unexpected behavior most times.

@dhasilva
Copy link
Contributor

dhasilva commented Sep 4, 2024

Should be fixed by the PR above. My guess was right there, it was an autofocus issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended
4 participants